Enable wsgi streaming conformance tests with pyvoy #51
+155
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
force-pushed
the
pyvoy-wsgi-streaming
branch
from
c047329 to
d5b0571
Compare
Signed-off-by: Anuraag Agrawal <[email protected]>
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
force-pushed
the
pyvoy-wsgi-streaming
branch
from
9c04be0 to
356f7a8
Compare
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
commented
Nov 18, 2025
| port_future: asyncio.Future[int], | ||
| ): | ||
| args = ["--bind=127.0.0.1:0", "--threads=40", "--reuse-port"] | ||
| args = [ |
Collaborator
Author
There was a problem hiding this comment.
Since updating conformance to have connection reuse, gunicorn would have some flakes. A bit disappointed since the vanguard has been so robust otherwise, but doing some research it seems a lot of settings assume nginx in front of gunicorn.
Through some random selection I got these settings to pass CI 3 times, but if anyone happens to know gunicorn better happy to hear any thoughts.
anuraaga
commented
Nov 18, 2025
| "pytest-cov==7.0.0", | ||
| "pytest-timeout==2.4.0", | ||
| "pyvoy==0.1.1; sys_platform != 'win32'", | ||
| "pyvoy==0.1.2; sys_platform != 'win32'", |
Collaborator
Author
There was a problem hiding this comment.
Fixed an issue that could sporadically hang with WSGI
stefanvanburen
approved these changes
Nov 18, 2025
i2y
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And tweaks gunicorn