Skip to content

exec:support to set custom log path#112

Open
ningmingxiao wants to merge 1 commit intocontainerd:mainfrom
ningmingxiao:custom_args
Open

exec:support to set custom log path#112
ningmingxiao wants to merge 1 commit intocontainerd:mainfrom
ningmingxiao:custom_args

Conversation

@ningmingxiao
Copy link
Copy Markdown
Contributor

@ningmingxiao ningmingxiao commented Jun 11, 2025 •
edited
Loading

I create a pr containerd/containerd#11862 to address containerd/containerd#8972
I want to specify runc log to custom path when exec .

@ningmingxiao ningmingxiao force-pushed the custom_args branch 5 times, most recently from 4646899 to 43fa230 Compare June 11, 2025 04:58
@ningmingxiao
Copy link
Copy Markdown
Contributor Author

ningmingxiao commented Jun 11, 2025 •
edited
Loading

ping @fuweid @AkihiroSuda @mikebrow can you review this pr thanks?

@ningmingxiao ningmingxiao force-pushed the custom_args branch 3 times, most recently from 3b92e61 to be762e7 Compare June 11, 2025 05:53
@ningmingxiao ningmingxiao mentioned this pull request Jun 11, 2025
Open
@ningmingxiao ningmingxiao force-pushed the custom_args branch 9 times, most recently from 1e7ee71 to 8e276f3 Compare June 11, 2025 09:57
mikebrow
mikebrow approved these changes Jun 11, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ningmingxiao
Copy link
Copy Markdown
Contributor Author

ningmingxiao commented Jun 11, 2025

thank you

AkihiroSuda
AkihiroSuda reviewed Jun 12, 2025
View reviewed changes
Comment thread runc.go Outdated
@fuweid fuweid self-requested a review June 12, 2025 12:21
mikebrow
mikebrow reviewed Jun 13, 2025
View reviewed changes
Comment thread runc.go Outdated
@ningmingxiao
exec:support to set custom log path
9238bac 
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
@ningmingxiao
Copy link
Copy Markdown
Contributor Author

ningmingxiao commented Jun 18, 2025

ping @fuweid

@ningmingxiao
Copy link
Copy Markdown
Contributor Author

ningmingxiao commented Jun 24, 2025 •
edited
Loading

@thaJeztah can you review this pr? docker may have same issue.

@ningmingxiao
Copy link
Copy Markdown
Contributor Author

ningmingxiao commented Jul 25, 2025

‌PTAL‌ @dmcgowan try to fix containerd/containerd#8972

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jul 25, 2025

Looks like this PR will auto-close the containerd issue because the PR description has "to fix <ticket>"

Can someone with permissions edit the description to remove that part (change it to "to address")?

@ningmingxiao
Copy link
Copy Markdown
Contributor Author

ningmingxiao commented Jul 25, 2025

Looks like this PR will auto-close the containerd issue because the PR description has "to fix <ticket>"

Can someone with permissions edit the description to remove that part (change it to "to address")?

done

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Jul 25, 2025

Thx! Commented from my phone, and didn't review yet, but thought I'd comment before github got trigger happy and close the ticket pre-maturely ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid Awaiting requested review from fuweid

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

@mikebrow mikebrow Awaiting requested review from mikebrow

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ningmingxiao @thaJeztah @AkihiroSuda @mikebrow