Closed
Conversation
6d1d9f3 to
c92867d
Compare
Contributor
Author
|
hey @AkihiroSuda Most of my PRs are failing the CIs. If this is it ^, did the cni-plugins folks do something messy? |
Member
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
c92867d to
3ff5a90
Compare
Contributor
Author
|
@AkihiroSuda I am closing this. There is a lot more work needed to fix image inspect which I am currently working on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overall, this enhances
image inspect:RepoTagsimage inspectwill coalesce into one array, instead of a stream of arraysIn the process, we stopped calling on the image Walker which serves little to no purpose here, hence significantly reducing the complexity.
This mainly fixes #3004 and part of #3006.
After this, more work is needed overall for inspect across objects, and then some specifically for image inspect.