Skip to content

image inspect fixes & cleanup#3008

Closed
apostasie wants to merge 1 commit intocontainerd:mainfrom
apostasie:dev-image-inspect
Closed

image inspect fixes & cleanup#3008
apostasie wants to merge 1 commit intocontainerd:mainfrom
apostasie:dev-image-inspect

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

Overall, this enhances image inspect:

  • multiple images with the same digest are now coalesced properly into one, with multiple RepoTags
  • multiple images resulting for multiple arguments in the call to image inspect will coalesce into one array, instead of a stream of arrays
  • ImageFromNative has been cleaned-up and simplified, making room for later addition of currently missing properties

In the process, we stopped calling on the image Walker which serves little to no purpose here, hence significantly reducing the complexity.

This mainly fixes #3004 and part of #3006.

After this, more work is needed overall for inspect across objects, and then some specifically for image inspect.

@apostasie apostasie force-pushed the dev-image-inspect branch from 6d1d9f3 to c92867d Compare May 15, 2024 08:34
@apostasie
Copy link
Copy Markdown
Contributor Author

hey @AkihiroSuda

Most of my PRs are failing the CIs.
Looks like:

#85 1.141 cni-plugins-linux-amd64-v1.4.1.tgz: FAILED
#85 1.142 sha256sum: WARNING: 1 of 1 computed checksums did NOT match

If this is it ^, did the cni-plugins folks do something messy?

@AkihiroSuda
Copy link
Copy Markdown
Member

Asking in:

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie apostasie force-pushed the dev-image-inspect branch from c92867d to 3ff5a90 Compare May 15, 2024 16:55
@apostasie
Copy link
Copy Markdown
Contributor Author

@AkihiroSuda I am closing this.

There is a lot more work needed to fix image inspect which I am currently working on.
I'll reopen a more thorough PR (hopefully with tests) once I am fully done.

@apostasie apostasie closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current implementation of images inspect is faulty (eg: RepoTags)

2 participants