Skip to content

Alleviate image --filter missing digest issue #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

apostasie
Copy link
Contributor

See #3512 #3513 #3516 for some context.

In a shell, filtering requires config to be there.
With multi-arch / non-native arch, retrieving the config might fail for specific images, which will fail the entire operation.

Turning this into a soft failure to alleviate the pain.

@apostasie
Copy link
Contributor Author

apostasie commented Oct 12, 2024

@AkihiroSuda ready to go. This will definitely squash some of the flakyness.

Pending CI. Windows failure is just the same as usual.

@apostasie apostasie marked this pull request as ready for review October 12, 2024 04:15
@apostasie
Copy link
Contributor Author

What about we just disable this TestRunWithTtyAndDetached test?
At least until the windows folk look into it.
It is just failing almost constantly - even with retries.

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Oct 12, 2024
@AkihiroSuda
Copy link
Member

What about we just disable this TestRunWithTtyAndDetached test? At least until the windows folk look into it. It is just failing almost constantly - even with retries.

I think we should just skip it

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit ce1fb30 into containerd:main Oct 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants