-
Notifications
You must be signed in to change notification settings - Fork 650
CI, build 2: Move GHA to zstd #3984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
EL8 did time-out. Apparently stuck somewhere in containers tests. |
8565c1e
to
fdf6965
Compare
Needs rebase. (For small amount of changes you do not need to split them into multiple PRs) |
Really. So, which is it? |
Signed-off-by: apostasie <[email protected]>
fdf6965
to
98a531a
Compare
x
I don't want to get into an argument here. |
Sorry, it is hard to have a consistent convention, but I thought the following ones could be optionally merged to a single PR because they are quite small, modify the same file, and unlikely controversial:
The situation seemed different for other ones though:
Anyway, feel free to submit PRs in the finer granularity when you are not sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Changing compression is a huge deal. Same for how we shard our cache.
Renaming variables for readability has no impact whatsoever on the product, nor on the CI behavior. IMHO "controversial" should not be defined by potential for bike-shed (assuming that was your point), but by "risk" and "impact".
Sorry, I will not. I am fine doing it for maintainers quality of life, when there is clear and rational reasons.
Thank you. |
For context, see #3940, #3924, and the start of this PR cycle at #3983.
On top of #3983
This moves caching to zstd.
Given the bottleneck with gha is IO and not compute, this is not likely to have an impact on speed - but it will on cache size.