Skip to content

CI: update Canary and EL8 titles #3989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

apostasie
Copy link
Contributor

Fix #3988

@apostasie apostasie changed the title Update Canary and EL8 titles CI: update Canary and EL8 titles Mar 5, 2025
@apostasie apostasie marked this pull request as ready for review March 5, 2025 04:18
@apostasie
Copy link
Contributor Author

apostasie commented Mar 5, 2025

rootful 2.0.3 failure is #3513

canary and EL8 failure demonstrate the point of this PR

@@ -423,7 +423,7 @@ jobs:
# Do not upgrade this to EL9 (cgroup v2).
test-integration-el8:
timeout-minutes: 60
name: "EL8 (cgroup v1)"
name: "[see #3988] EL8 (cgroup v1)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I can't get how EL8 is configured here ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fahedouch not sure what you are asking? but yeah, this one is somewhat tricky.
Alma 8 (which is the current EL derivative used here) is started in a Lima VM:

limactl start \
--name=default \
--cpus=4 \
--memory=12 \
--containerd=none \
--set '.mounts=null | .portForwards=[{"guestSocket":"/var/run/docker.sock","hostSocket":"{{.Dir}}/sock/docker.sock"}]' \
template://almalinux-8

Then we run the normal integration test suite inside an Ubuntu container (but of course with the EL 4.18 kernel).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes! thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand correctly, the MR is mergeable with the current issues ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the maintainers should make a case by case call.

At least the contributors should not spend too much time trying to figure out what is up with these targets, and yes, IMO the maintainers may make judgment calls that "broken canary because of Hub carfuffle" should not prevent merging.

I do not know what are the current merge settings of the repo and if they require a green run though - up to you folks if you want to adjust that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failure are note related to your PR, So for me it is mergeable!

@AkihiroSuda AkihiroSuda added this to the v2.0.4 milestone Mar 7, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Mar 7, 2025
@apostasie
Copy link
Contributor Author

rootless failure is Docker Hub 429.

Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch merged commit 0d7f52c into containerd:main Mar 11, 2025
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci e.g., CI failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: mark targets as "read for perspective"
3 participants