-
Notifications
You must be signed in to change notification settings - Fork 648
CI: update Canary and EL8 titles #3989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rootful 2.0.3 failure is #3513 canary and EL8 failure demonstrate the point of this PR |
.github/workflows/test.yml
Outdated
@@ -423,7 +423,7 @@ jobs: | |||
# Do not upgrade this to EL9 (cgroup v2). | |||
test-integration-el8: | |||
timeout-minutes: 60 | |||
name: "EL8 (cgroup v1)" | |||
name: "[see #3988] EL8 (cgroup v1)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry but I can't get how EL8
is configured here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fahedouch not sure what you are asking? but yeah, this one is somewhat tricky.
Alma 8 (which is the current EL derivative used here) is started in a Lima VM:
nerdctl/.github/workflows/test.yml
Lines 469 to 475 in d1f4890
limactl start \ | |
--name=default \ | |
--cpus=4 \ | |
--memory=12 \ | |
--containerd=none \ | |
--set '.mounts=null | .portForwards=[{"guestSocket":"/var/run/docker.sock","hostSocket":"{{.Dir}}/sock/docker.sock"}]' \ | |
template://almalinux-8 |
Then we run the normal integration test suite inside an Ubuntu container (but of course with the EL 4.18 kernel).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes! thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I understand correctly, the MR is mergeable with the current issues ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the maintainers should make a case by case call.
At least the contributors should not spend too much time trying to figure out what is up with these targets, and yes, IMO the maintainers may make judgment calls that "broken canary because of Hub carfuffle" should not prevent merging.
I do not know what are the current merge settings of the repo and if they require a green run though - up to you folks if you want to adjust that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failure are note related to your PR, So for me it is mergeable!
Signed-off-by: apostasie <[email protected]>
rootless failure is Docker Hub 429. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Fix #3988