[Feat] Add commit compression type support

[lengrongfu]

Fix #4060

Use zstd compression can shorten commit time. current containerd v2 having support zstd commit type, but containerd v1 version don't support.

Test case:

1. create nginx pod, write a 5G file.

#!/bin/sh
for ((i=1; i<=5; i++))
do
  dd if=/dev/urandom of=$i".txt" bs=500M count=2
done

2. use zstd compression to commit container only need 29s time.

$ nerdctl -n k8s.io commit ca45e0595384b14ee1fbef6f0a38efb2a2725471cb8fc143d9720a068d8b6cb1 easzlab.io.local:5000/demo/nginx:v2 --pause=true --compression=zstd

to view blob type.

$ nerdctl -n k8s.io image inspect --mode=native easzlab.io.local:5000/demo/nginx:v2

3. use gzip compression to commit container need 2m5s time.

$ nerdctl -n k8s.io commit ca45e0595384b14ee1fbef6f0a38efb2a2725471cb8fc143d9720a068d8b6cb1 easzlab.io.local:5000/demo/nginx:v3 --pause=true

[apostasie]

CI is failing right now - bustage will be fixed by #4058

[lengrongfu]

@yankay @AkihiroSuda please take a look， thanks.

[AkihiroSuda]

CI is failing

[apostasie]

@lengrongfu could we have a test? eg: commit with zstd, then use that image.

[lengrongfu]

easzlab.io.local:5000/demo/nginx:v2

Yes, I test, can use zstd commit image to deployment pod.

[lengrongfu]

@AkihiroSuda @apostasie Please take a look, thanks ~

[apostasie]

easzlab.io.local:5000/demo/nginx:v2

Yes, I test, can use zstd commit image to deployment pod.

Thanks @lengrongfu

We need a test that can run on the CI. Eg, like in: https://github.com/containerd/nerdctl/blob/main/cmd/nerdctl/container/container_commit_test.go

[apostasie]

@lengrongfu Code is fine (beside a couple of minor nits above), but my main issues right now are:

• we need a test
• curious if I select zstd what will happen with containerd v1?

[lengrongfu]

In containerd v1 becase it don't support ocispec.MediaTypeImageLayerZstd this type , so
it will return error like unsupported diff media type https://github.com/containerd/containerd/blob/befa4ce6e99a8e8d56d1eb2e7db1d2173e1406c5/diff/walking/differ.go#L89-L94

[lengrongfu]

@apostasie about TestZstdCommit this all test ci running success. please agaen take a look. thanks~

[apostasie]

@apostasie about TestZstdCommit this all test ci running success. please agaen take a look. thanks~

Thanks a lot @lengrongfu !
Appreciate all the efforts here.

I do have a small series of comments here - mainly typos, and a suggestion for the test.

Let me know what you think and then it should be good for final review.

[lengrongfu]

@apostasie Modified according to your suggestion, thank you for your work.

[apostasie]

Thanks @lengrongfu

LGTM.

CI failure is unrelated.

Now to maintainers - @AkihiroSuda @yankay @fahedouch PTAL

[AkihiroSuda]

semver should be used

nerdctl/pkg/taskutil/taskutil.go

Line 144 in 772bb09

} else if sv.LessThan(semver.MustParse("1.6.0-0")) {

[lengrongfu]

done

[AkihiroSuda]

Suggested change

	var ContainerdVersionV2 = &test.Requirement{
	func ContainerdVersion(v string) = &test.Requirement{

So that we do not need to add ContainerdVersionV2_1, ContainerdVersionV2_2, ContainerdVersionV3, ... for each of the versions

[lengrongfu]

test.Requirement is struct, how to set to func ContainerdVersion(v string)?

[AkihiroSuda]

I meant to make it a function that returns *test.Requirement

[lengrongfu]

got it, thanks.

[fahedouch]

thanks @lengrongfu .

The documentation update is good, but it might be helpful to add a brief explanation of when to use each compression type (e.g., zstd is generally better for compression ratio but might not be as widely supported).

[fahedouch]

Thanks