fix: Pass ps_args as option to container top #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjun Raja Yogidas <[email protected]>
1 task
|
What was the issue? |
|
Updated the PR description |
fahedouch
reviewed
Apr 1, 2025
|
@AkihiroSuda PTAL when you get a chance |
|
Retrying for flaky tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the arguments for the ps command is parsed out in the top.go file
this PR moves the parsing logic to the parent function and passes the parsed values via a new field in the ContainerTopOptions
This will enable nerdctl lib users to pass ps_args values.
Tests are already present for these in cmd/nerdctl/container/container_top_test.go
I've just moved the parsing from child function to parent, no change in logical behavior