[Tigron]: command env WhiteList support and cosmetic changes #4077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
apostasie
changed the title
1 task
apostasie
force-pushed
the
tigron-2-debugging
branch
from
6a34138 to
c6d4dc9
Compare
|
Rebased. |
apostasie
force-pushed
the
tigron-2-debugging
branch
from
c6d4dc9 to
a35b429
Compare
apostasie
changed the title
|
Rebased. Ready for review. |
|
CI failures are:
|
AkihiroSuda
reviewed
Apr 12, 2025
AkihiroSuda
reviewed
Apr 12, 2025
Prior, only BlackList-ing of environment variables was supported, and solely for exact variable names match, or "*" for all. This changeset introduces: - WhiteList-ing - prefix matching for env var names (eg: "THING_*" can now be used to white/black list any env variable which name starts with THING_) Note that whitelisting takes precedence over blacklisting if both are used. Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
tigron-2-debugging
branch
from
a35b429 to
1e0b404
Compare
|
Thanks for the review @AkihiroSuda. Appreciated. |
This is mostly a cosmetic changeset: - refined golangcilint, explicitly calling which linters we really care about, along with settings for revive - comments on reasons for some of //nolint - comments line breaks - additional FIXME information - assert type check fixes - const-ification - overall making linter happy(-ier) Signed-off-by: apostasie <[email protected]>
apostasie
force-pushed
the
tigron-2-debugging
branch
from
1e0b404 to
734f7a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<!> Blocked by <!>:
This is a new series of Tigron PRs.
Now that the big change with the new command implementation is in, upcoming work on Tigron will focus on:
Ideally, none of these PRs will require ANY change in nerdctl, and are either changes to the way we test Tigron itself, or refactoring that does not change signatures and API.
Efforts are being made to break these PRs down into small, digestible changes to ease and fasten review, which explains the chain of PRs.
LMK at any point if a given PR needs to be further broken down.
This second PR is very small:
Commit 1 adds support for environment whitelisting for
internal/com.The point here is to make the output on the CI a lot less crowded (since we do output the command environment, there is a lot of irrelevant stuff in there - ANDROID stuff, etc - and blacklisting one by one is a wild goose chase).
Second commit is cosmetic / refining linting.