-
Notifications
You must be signed in to change notification settings - Fork 651
[CI]: rewrite some container and compose tests #4122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3a345b4
to
2a88d6a
Compare
Failures are:
|
2a88d6a
to
d9546ec
Compare
Needs rebase |
d9546ec
to
6bcdc42
Compare
Rebased. Thanks for all the merges @AkihiroSuda I'll do another proof-reading of this right now. |
Failures are a bunch of existing EL8 specific fails. |
Signed-off-by: apostasie <[email protected]>
6bcdc42
to
ff8b599
Compare
Rebasing for good measure. |
Failure is again buildg timeout. I do not have a good explanation for why we are seeing this so much now.
#4103 should get to the root cause eventually, but it is an excruciating process to nail flaky behavior in third party binaries... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope we can try to reduce PR sizes in future PRs.
I know it is painful to review large PRs like that, but I believe there is really no other way here - and at the end of the day, this is only tests - the CI being green is proof in the pudding.
I would suggest at least split the PR by areas, e.g., one for compose
, one for image
, one for container
.
That is fair - will do. Thanks @djdongjin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I have been delaying engaging with compose and container tests so far because of the daunting amount of work...
But at this point, they are the number one contributor to overall slowness (and most of remaining flakyness).
Moving these will cut through the total runtime and make a dent in the bucket of "tests with retries".
Note that we should merge first, before this:- #4111- #4081- #4116and preferably #4114.... as this PR does leverage some of the recent changes in Tigron (specifically temp files manipulation).I will obviously take care of rebasing once they are in, though the last commit of this PR could be reviewed already at this point.Note that this PR also adopt / cleans-up / remove deprecated helpers (some of them wrongly located under
./cmd
, some under./pkg/testutil
).I know it is painful to review large PRs like that, but I believe there is really no other way here - and at the end of the day, this is only tests - the CI being green is proof in the pudding.