async/client: Fix unary request timeout cleanup - #318
Open
Tim-Zhang wants to merge 1 commit into
Open
Conversation
Use one deadline while waiting for both the outbound queue and the response. Remove stream registrations when requests time out or are cancelled. Discard requests that expire before writing. Close the connection when a timeout or cancellation interrupts an in-progress write because the frame may be incomplete. Return writer failures through the task result. Add regression tests for full queues, response cleanup, queued request timeout errors, and cancellation during writes. Fixes: #317 Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
marked this pull request as ready for review
August 6, 2026 10:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The previous timeout only covered waiting for the response after the request entered the outbound queue. A request could therefore outlive its timeout while the queue or socket was blocked, and timed-out or cancelled requests could leave stream registrations behind.
Validation
cargo +1.95.0 test --features asynccargo +1.95.0 clippy --all-targets --features async -- -D warningscargo +1.95.0 fmt --all --checkgit diff --checkFixes #317