host-device: support wireless PHY namespace moves#1274
Draft
mbaragiola wants to merge 1 commit into
Draft
Conversation
Author
|
CI is currently blocked by dependency sequencing, not by the GitHub runner and not by a separate defect found in this CNI diff. Exact evidence:
Note that netlink PR #1203 itself currently has an unrelated Linux check failure: run No CNI code or module files were changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add wireless PHY support to the
host-deviceCNI plugin.Linux wireless devices cannot be moved with the ordinary
RTM_SETLINK/LinkSetNsFdpath. This change detects wireless interfaces through sysfs and uses thenl80211wiphy move operation instead.Safety behavior:
Dependency
This PR depends on the Linux-only API proposed in:
The current declared
vishvananda/netlink v1.3.1does not containWiphySetNsFd, so this PR is intentionally opened as a draft until that API is accepted and released (or the maintainers advise on dependency sequencing).Related issue: #957
Testing
go vetforplugins/main/host-devicewith the temporary local replacement: passed.gofmtandgit diff --check: passed.go.modandgo.sumremain unchanged.operation not permitted.