libkrun: avoid failing when libkrunfw is missing #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the last iteration of PR#256 we introduced the use of LazyLock, which helps us load the library earlier. The implementation was wronging because we were unwrapping if the library is missing, which is exactly what we were trying to prevent. Replace the value with an Option, which allows us to avoid the unwrap and actually achieves the purpose of making libkrunfw optional. Signed-off-by: Sergio Lopez <[email protected]>
slp
requested review from
jakecorrenti,
MatiasVara,
mtjhrc and
tylerfanelli
as code owners
|
Probably should have tested with a missing libkrunfw :) my mistake |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the last iteration of PR#256 we introduced the use of LazyLock, which helps us load the library earlier. The implementation was wronging because we were unwrapping if the library is missing, which is exactly what we were trying to prevent.
Replace the value with an Option, which allows us to avoid the unwrap and actually achieves the purpose of making libkrunfw optional.