Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff and black disagree on what the code should look like #1142

Open
italomaia opened this issue Feb 18, 2025 · 0 comments
Open

Ruff and black disagree on what the code should look like #1142

italomaia opened this issue Feb 18, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@italomaia
Copy link
Contributor

Just noticed ruff podman_compose.py and black podman_compose.py generate two different outputs that fail for checks against one-another. As pre-commit checks against black and the ci checks against ruff, and the contribution guide suggests setting up pre-commit, it would be reasonable to either alter pre-commit by replacing black or the ci by replacing ruff.

To Reproducte

black podman_compose.py
ruff podman_compose.py

Expected behavior
It should be possible to align the code against a single code formatter.

Actual behavior
Ruff and Black disagree on what "properly formatted" looks like.

Environment:

  • OS: Linux
  • podman-compose version 1.3.0
  • podman version 4.9.3

Additional context

Tested against main branch.

@italomaia italomaia added the bug Something isn't working label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant