Bug: replaced black with ruff on pre-commit #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
italomaia
force-pushed
the
bug/use-ruff
branch
from
2784437 to
6a273b4
Compare
italomaia
changed the title
|
Looks good. Please limit commit message line length to 72 chars and split it into message subject and message body parts. See https://cbea.ms/git-commit/ for some other guidelines |
|
Can do; minute |
italomaia
force-pushed
the
bug/use-ruff
branch
2 times, most recently
from
8818442 to
da1c3a1
Compare
|
Done. |
Current python files are already compatible with ruff, while very incompatible with black standard therefore, this change just enforces the reality of the codebase. Without it, pre-commit and the ci will fight one-another with different formatting. Signed-off-by: Italo Maia <[email protected]>
Added flake8 excludes to rules that are already ignored by the current code to avoid validation issues with code that has already been approved. Added pylint disable to line with lint offense already accepted. Signed-off-by: Italo Maia <[email protected]>
p12tic
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Checklist:
As black and ruff have a different idea on how the formatted code should look like, by using pre-commit, which is advised in the contributing guide, we block any contribution, as ruff is used in the ci format check and black is used in the pre-commit. This MR fixes this: #1142