-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle SIGINT when running "up" command to shutdown gracefully #1148
Conversation
Thanks for the contribution. The PR looks good in principle, I'm just not confident enough with the Separately, pylint is complaining in https://github.com/containers/podman-compose/actions/runs/13497452404/job/37707798339?pr=1148. I think both warnings can be disabled in .pylintrc. |
About the line that you mentioned (down arguments) I actually used the same line already used somewhere else in the code: podman-compose/podman_compose.py Line 2742 in bcce413
I guess it should work enough, but we can modify in case of improvements.
Oh I didn't check for warning here. I changed the code about the second one so that it passes now, but for the first one, I added it to |
@p12tic is there anything else blocking this merge? |
@pablo-tx @mokazemi Sorry for taking a long time to reply. Code changes look good. Please rebase on top of latest main branch and fix merge conflicts. Also please add a release note to the newsfragments directory (you can look here for inspiration on how release note looks like). Also DCO test fails - it asks for |
… function for a graceful shutdown Signed-off-by: Mohammad Kazemi <[email protected]>
Signed-off-by: Mohammad Kazemi <[email protected]>
Signed-off-by: Mohammad Kazemi <[email protected]>
Signed-off-by: Mohammad Kazemi <[email protected]>
efc6bbc
to
f5a6df6
Compare
Done. @p12tic |
This pull request enhances the podman compose behavior by handling the
Ctrl+C
(SIGINT) signal more gracefully. WhenCtrl+C
is pressed during the execution of podman compose up, it runs thedown
command to make sure containers shut down gracefully.Solves: #51, #112, #411, #436, #457, #543, #676