Remove Intel Apple builds and artifacts (refactor) #203
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
baude
changed the title
|
same as #202 but refactored for future considerations ... |
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
I dunno about all this special casing and small differences in doing things and the likes but honestly I tried to look at things to somehow make this "cleaner" but I cannot think of anything that would look better than this so lets go with this.
But there is one logic error that needs fixing, LGTM otherwise
util.sh
Outdated
| # WSL also produces an uncompressed tar artifact | ||
| if [[ " $platforms " =~ " wsl " ]]; then | ||
| result="$result tar" | ||
| fi |
There was a problem hiding this comment.
The comment is not right, the tar artifact is actually the coreos image as oci-archive not a disk image for a hypervisor.
As such this if condition doesn't add anything.
But also the value we add is wrong and will break the push script, the filename is podman-machine.$arch.tar so you are missing to add the arch part to the tar like you do for the actual disk images.
so this needs to be result="$result $arch.tar"
Podman will no longer support Intel Macs as of Podman 6. This PR removes our builds and artifacts for that platform. JIRA: RUN-3622 Signed-off-by: Brent Baude <[email protected]>
baude
force-pushed
the
removeintelapplecleaner
branch
from
1f97ea9 to
b0fad2b
Compare
2 participants
Podman will no longer support Intel Macs as of Podman 6. This PR removes our builds and artifacts for that platform.
JIRA: RUN-3622