Fix/#489

[Mr-Sunglasses]

fix: #489

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Mr-Sunglasses
Once this PR has been reviewed and has the lgtm label, please assign jwhonce for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lsm5]

/packit build
/packit test

[lsm5]

@inknos PTAL

[inknos]

@Mr-Sunglasses my sincere apologies for this PR taking so long, I postponed and forgot to review many times.

What about adding a type check on str here?

Also, this new function needs to be unit testes. I made an example here so you can tell me what you think.

diff --git a/podman/tests/unit/test_containersmanager.py b/podman/tests/unit/test_containersmanager.py
index 47b3048..44dd47c 100644
--- a/podman/tests/unit/test_containersmanager.py
+++ b/podman/tests/unit/test_containersmanager.py
@@ -16,6 +16,7 @@ from podman import PodmanClient, tests
 from podman.domain.containers import Container
 from podman.domain.containers_manager import ContainersManager
 from podman.errors import ImageNotFound, NotFound
+from podman.domain.containers_create import CreateMixin
 
 FIRST_CONTAINER = {
     "Id": "87e1325c82424e49a00abdd4de08009eb76c7de8d228426a9b8af9318ced5ecd",
@@ -313,6 +314,25 @@ class ContainersManagerTestCase(unittest.TestCase):
         with self.assertRaises(TypeError):
             self.client.containers.create("fedora", "/usr/bin/ls", unknown_key=100.0)
 
+    @requests_mock.Mocker()
+    def test_create_convert_env_list_to_dict(self, mock):
+        env_list1 = ["FOO=foo", "BAR=bar"]
+        # Test valid list
+        converted_dict1 = { "FOO": "foo", "BAR": "bar" }
+        self.assertEqual(CreateMixin._convert_env_list_to_dict(env_list1), converted_dict1)
+
+        # Test empty string
+        env_list2 = ["FOO=foo", ""]
+        self.assertRaises(ValueError, CreateMixin._convert_env_list_to_dict, env_list2)
+
+        # Test non iterable
+        env_list3 = ["FOO=foo", None]
+        self.assertRaises(ValueError, CreateMixin._convert_env_list_to_dict, env_list3)
+
+        # Test iterable with non string element
+        env_list4 = ["FOO=foo", []]
+        self.assertRaises(ValueError, CreateMixin._convert_env_list_to_dict, env_list4)
+
     @requests_mock.Mocker()
     def test_run_detached(self, mock):
         mock.post(

The rest LGTM, please ping me when you are done so I will give you quick attention