Improve testing against distro and podman-next #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsm5
reviewed
May 2, 2025
lsm5
approved these changes
May 2, 2025
inknos
force-pushed
the
testing-podman-pnext
branch
5 times, most recently
from
f0cf021 to
97791aa
Compare
|
/packit test --labels pnext |
|
@lsm5 all is good now (except for cirrus which is red because it uses as said privately, this is a problem that we cannot get around that easily for cirrus. disabling the copr, is surely a quick fix, but it would prevent us from testing upstream changes |
lsm5
reviewed
May 5, 2025
lsm5
reviewed
May 5, 2025
lsm5
approved these changes
May 5, 2025
|
/hold |
1. Split upstream into distro/pnext test runs
A new CI run targets tests that are exclusive for podman-next.
/upstream plans are now split into /distro and /pnext to be explicit
against which podman version is used in the tests. Also, python version
used are now called base_python and all_python, to be more self
explainatory.
2. Add pytest marker `pnext` to filter tests
Tests that should run against podman-next are now skipped by default in
tox runs. They can be enabled with --pnext and filtered in using
`-m pnext`. These two options should be used together since `pnext` and
`non-pnext` tests are thought to be incompatible.
3. Split `test_container_mounts` to test a breaking change and update
docs
The scenario `test_container_mounts` was split to demonstrates the
usage of the marker against an upstream breaking change.
CONTRIBUTING.md now reflects the new feature and explains how to use tox
locally to leverage on this feature.
4. Add manual trigger on packit
Since the tests cover a corner case and serve the purpose of testing
unreleased features of libpod (which is slightly out of the scope of
podman-py) the testing jobs are optional and should run for certain PRs
only. The command to run the pnext tests is the following.
/packit test --labels {pnext,podman_next}
Fixes: containers#547
Signed-off-by: Nicola Sella <[email protected]>
inknos
force-pushed
the
testing-podman-pnext
branch
from
97791aa to
f3b8f1d
Compare
Cirrus is now redundant with tmt. Also, with the recent change, cirrus would need to be updated and reworked to work with podman-next and without it. Also, replace badge in the README Signed-off-by: Nicola Sella <[email protected]>
inknos
force-pushed
the
testing-podman-pnext
branch
from
d9b1daf to
cec8a83
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new CI run targets tests that are exclusive for podman-next. /upstream plans are now split into /distro and /pnext to be explicit against which podman version is used in the tests. Also, python version used are now called base_python and all_python, to be more self explainatory.
pnextto filter testsTests that should run against podman-next are now skipped by default in tox runs. They can be enabled with --pnext and filtered in using
-m pnext. These two options should be used together sincepnextandnon-pnexttests are thought to be incompatible.test_container_mountsto test a breaking change and update docsThe scenario
test_container_mountswas split to demonstrates the usage of the marker against an upstream breaking change. CONTRIBUTING.md now reflects the new feature and explains how to use tox locally to leverage on this feature.Since the tests cover a corner case and serve the purpose of testing
unreleased features of libpod (which is slightly out of the scope of
podman-py) the testing jobs are optional and should run for certain PRs
only. The command to run the pnext tests is the following.
/packit test --labels {pnext,podman_next}
Fixes: #547
cc: @lsm5