Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions skills/code-review/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,3 @@ description: PR expectations and review checklist for the DataSync AWS S3 asset
- **Blocker**: broken build, failing tests, secret leak, or breaking change without semver/docs
- **Major**: missing tests for non-trivial logic, unclear error handling for S3/network failures
- **Minor**: naming, comment updates, small refactors for readability

## References

- [`../datasync-asset-store-s3/SKILL.md`](../datasync-asset-store-s3/SKILL.md) — API surface
- [`../testing/SKILL.md`](../testing/SKILL.md) — test expectations
6 changes: 0 additions & 6 deletions skills/datasync-asset-store-s3/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,3 @@ description: Public API, S3 asset store class, configuration, and DataSync Manag
### Versioning

- Follow semver for npm releases; breaking changes to `start`’s resolved object or config contract need a major bump and README/changelog updates

## References

- [`../typescript-style/SKILL.md`](../typescript-style/SKILL.md) — TypeScript layout
- [`../framework/SKILL.md`](../framework/SKILL.md) — AWS SDK and S3 specifics
- [`README.md`](../../README.md) — end-user configuration tables
6 changes: 0 additions & 6 deletions skills/dev-workflow/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,3 @@ description: Branches, local commands, Husky pre-commit (Talisman/Snyk), and Git

- Use feature branches; target the repo’s default branch per team process (not hard-coded here)
- Keep changes scoped; this package is consumed by DataSync Manager—avoid breaking the exported `start` / asset store contract without coordination

## References

- [`../datasync-asset-store-s3/SKILL.md`](../datasync-asset-store-s3/SKILL.md) — public API and integration
- [`../testing/SKILL.md`](../testing/SKILL.md) — Jest and coverage
- [DataSync Manager](https://github.com/contentstack/datasync-manager) — consumer integration
7 changes: 1 addition & 6 deletions skills/framework/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ description: AWS SDK v2, S3 usage, streaming uploads, and runtime assumptions fo

### AWS SDK

- Library uses **`aws-sdk`** v2 (not AWS SDK for JavaScript v3 modular clients)
- Library uses **`aws-sdk`** v2 (not AWS SDK for JavaScript v3 modular clients); class reference: [AWS.S3](https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html)
- S3 client is constructed in [`src/setup.ts`](../../src/setup.ts) and injected into [`S3`](../../src/s3.ts)

### Streaming and HTTP
Expand All @@ -30,8 +30,3 @@ description: AWS SDK v2, S3 usage, streaming uploads, and runtime assumptions fo
### Node.js

- Target runtime is **Node >= 22** per `engines`; avoid APIs that require newer Node unless `engines` and docs are updated together

## References

- [`../datasync-asset-store-s3/SKILL.md`](../datasync-asset-store-s3/SKILL.md) — config and public API
- [AWS SDK for JavaScript v2 — S3](https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/S3.html)
5 changes: 0 additions & 5 deletions skills/testing/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,3 @@ description: Jest + ts-jest setup, test file locations, coverage, and safe handl
### Coverage

- Reports: `coverage/` (JSON + HTML per Jest config); ensure new code paths are covered when fixing bugs or adding behavior

## References

- [`../dev-workflow/SKILL.md`](../dev-workflow/SKILL.md) — `npm test` in local workflow
- [`../framework/SKILL.md`](../framework/SKILL.md) — AWS S3 behavior under test
5 changes: 0 additions & 5 deletions skills/typescript-style/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,3 @@ description: TypeScript compiler settings, source layout, and conventions for sr

- TSLint is the configured linter (`tslint.json`); run `npm run tslint` before merge
- Prefer existing patterns: class `S3` with public methods, small `util/` helpers, `debug` namespaces per file

## References

- [`../datasync-asset-store-s3/SKILL.md`](../datasync-asset-store-s3/SKILL.md) — exported API surface
- [`../dev-workflow/SKILL.md`](../dev-workflow/SKILL.md) — build commands
Loading