Use runtime cwd for data-dir flag #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: use runtime cwd for data-dir flag
AryanBansal-launch
approved these changes
Jan 28, 2026
tejas-contentstack
approved these changes
Jan 28, 2026
There was a problem hiding this comment.
Pull request overview
Updates the launch:functions command so the default data-dir resolves to the runtime working directory (instead of being captured at module-load time), and adds a regression test to cover the fallback behavior.
Changes:
- Remove the static
process.cwd()default from thedata-dirflag definition. - Compute
projectBasePathat runtime ininit()usingprocess.cwd()when the flag is not provided. - Add a unit test verifying the runtime fallback to
process.cwd().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/commands/launch/functions.ts | Moves data-dir defaulting to runtime within init() for correct cwd resolution. |
| src/commands/launch/functions.test.ts | Adds coverage to ensure data-dir falls back to process.cwd() when unset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: use runtime cwd for data-dir flag