Skip to content

ui feedback on assistant refresh #5269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

uinstinct
Copy link
Contributor

Description

Added loading in reload icon present inside assistant selection menu. This adds a user UI feedback indicating that the config is being reloaded instead of waiting for "Config refreshed" message which appears after delay.

Checklist

  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

before.mp4
after.mp4

Testing instructions

  1. go to the chat area
  2. click on the assistant selection dropdown
  3. click on the refresh icon to reload the configs/assistants
  4. check the new loading indicator on the refresh icon

@uinstinct uinstinct requested a review from a team as a code owner April 21, 2025 16:13
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team April 21, 2025 16:13
Copy link

netlify bot commented Apr 21, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 42d1241
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/68070e83650f1c0008059f07

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was bothering me a bit too, thanks for the improvement! And videos as always 🙏

Just one nitpick, I prefer our spin-slow since the default animate-spin in Tailwind feels too fast for me in most cases.

buttonRef.current?.click();
}}
>
<ArrowPathIcon className="text-lightgray h-2.5 w-2.5" />
<ArrowPathIcon className={cn("text-lightgray h-2.5 w-2.5", loading && 'animate-spin')} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<ArrowPathIcon className={cn("text-lightgray h-2.5 w-2.5", loading && 'animate-spin')} />
<ArrowPathIcon className={cn("text-lightgray h-2.5 w-2.5", loading && 'spin-slow')} />

https://github.com/continuedev/continue/blob/main/gui/tailwind.config.cjs#L26

@Patrick-Erichsen Patrick-Erichsen merged commit 364149b into continuedev:main Apr 28, 2025
31 checks passed
@uinstinct uinstinct deleted the assistant-refresh-feedback branch April 29, 2025 03:19
@DocMAX
Copy link

DocMAX commented May 5, 2025

my local assistans in ~/.continue/assistants/*.yaml are not loaded anymore?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants