Fix: Prioritize user-defined embed models over Transformers.js built-in #5555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When defining an embed model with `roles: [embed]` in the YAML config file, the extension defaults to using the built-in Transformers.js embedder instead of the user-defined model. ## Changes - Modified the embed model selection logic to prioritize user-defined models with the embed role - Only fall back to Transformers.js when no other embed models are defined - Updated model initialization to select the first non-Transformers.js model by default when available ## Testing - Tested with a custom embed model in config.yaml and confirmed it's automatically selected on startup
✅ Deploy Preview for continuedev canceled.
|
added 2 commits
May 7, 2025 12:36
…up logic into a separate helper function. This brings the complexity score of configYamlToContinueConfig below the maximum threshold of 36.
|
Nice find! I want to make sure we are able to test this, but I also understand that the work required to do that would probably blow up the scope of this PR. I'm going to make an attempt at doing this before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When defining an embed model with
roles: [embed]in the YAML config file, the extension defaults to using the built-in Transformers.js embedder instead of the user-defined model. This PR fixes this issue by ensuring user-configured embed models in config.yaml are prioritized over the built-in Transformers.js model.Changes Made
core/config/yaml/loadYaml.tsto:core/config/selectedModels.tsto prioritize non-Transformers.js models when selecting the initial embed modelTesting
I've tested these changes with a custom OpenAI-compatible embed model defined in config.yaml with
roles: [embed], and confirmed that:Checklist