Skip to content

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.0 - #9062

Merged
RomneyDa merged 1 commit into
mainfrom
snyk-fix-8e8ebf65a676d785d0d7d1635a746715
Dec 8, 2025
Merged

[Snyk] Security upgrade urllib3 from 2.0.7 to 2.6.0#9062
RomneyDa merged 1 commit into
mainfrom
snyk-fix-8e8ebf65a676d785d0d7d1635a746715

Conversation

@sestinj

@sestinj sestinj commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.

Snyk changed the following file(s):

  • packages/continue-sdk/python/api/requirements.txt

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Allocation of Resources Without Limits or Throttling


Summary by cubic

Upgrade urllib3 to >=2.6.0 in packages/continue-sdk/python/api/requirements.txt to fix two vulnerabilities (SNYK-PYTHON-URLLIB3-14192442, -14192443). Removes the <3.0.0 cap to standardize on a secure baseline.

Written for commit df86ba8. Summary will update automatically on new commits.

@sestinj
sestinj requested a review from a team as a code owner December 8, 2025 08:04
@sestinj
sestinj requested review from Patrick-Erichsen and removed request for a team December 8, 2025 08:04
@continue

continue Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 8, 2025
@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

⚠️ PR Title Format

Your PR title doesn't follow the conventional commit format, but this won't block your PR from being merged. We recommend using this format for better project organization.

Expected Format:

<type>[optional scope]: <description>

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

✅ Review Complete

Review of PR #9062: Security upgrade urllib3 from 2.0.7 to 2.6.0

Overall Assessment: ✅ This is a straightforward security upgrade that should be approved and merged.

Positive Aspects:

  • Addresses 2 security vulnerabilities (SNYK-PYTHON-URLLIB3-14192442, SNYK-PYTHON-URLLIB3-14192443) with high priority scores (731 each)
  • urllib3 2.6.0 is a stable, well-tested version
  • The change is minimal and focused

Potential Concerns:

  1. Breaking Change Risk - Minor Upper Bound Removal

    • Line 1: Removing the < 3.0.0 upper bound could potentially allow future automatic upgrades to urllib3 3.x, which would be a major version bump with breaking changes
    • Recommendation: Consider urllib3>=2.6.0,<3.0.0 to maintain explicit major version control while fixing the vulnerabilities
  2. Testing Coverage

    • No test changes included - ensure existing tests pass, especially any that make HTTP requests
    • Consider manual testing of any functionality that uses urllib3 (likely through the requests library or similar)
  3. Dependency Compatibility

    • Verify that other dependencies (especially requests if used) are compatible with urllib3 2.6.0
    • The jump from potentially 2.0.7 to 2.6.0 spans several minor versions

Recommendation:

APPROVE with the suggestion to consider restoring the <3.0.0 upper bound. The security fix is important and should be merged promptly. If CI passes, this is safe to merge.


@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@continue

continue Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

CI Failure Analysis

The CI failure in test (macos-latest, 24) appears to be a flaky test, not related to this PR's changes:

Evidence:

  • 11 out of 12 test matrix combinations passed (all Ubuntu and Windows variants with Node 18/20/22/24, plus macOS with Node 18/20/22)
  • Only test (macos-latest, 24) failed
  • This PR only modifies Python dependencies (urllib3 in packages/continue-sdk/python/api/requirements.txt)
  • The failing tests are Node.js/TypeScript tests in the CLI, completely unrelated to Python dependencies

Recommendation:

Re-run the failed workflow. The urllib3 security upgrade is safe and doesn't affect the CLI test suite.

Context:

This is a Snyk security fix upgrading urllib3 from >=1.25.3, <3.0.0 to >=2.6.0 to address vulnerabilities SNYK-PYTHON-URLLIB3-14192442 and SNYK-PYTHON-URLLIB3-14192443.

1 similar comment
@continue

continue Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

CI Failure Analysis

The CI failure in test (macos-latest, 24) appears to be a flaky test, not related to this PR's changes:

Evidence:

  • 11 out of 12 test matrix combinations passed (all Ubuntu and Windows variants with Node 18/20/22/24, plus macOS with Node 18/20/22)
  • Only test (macos-latest, 24) failed
  • This PR only modifies Python dependencies (urllib3 in packages/continue-sdk/python/api/requirements.txt)
  • The failing tests are Node.js/TypeScript tests in the CLI, completely unrelated to Python dependencies

Recommendation:

Re-run the failed workflow. The urllib3 security upgrade is safe and doesn't affect the CLI test suite.

Context:

This is a Snyk security fix upgrading urllib3 from >=1.25.3, <3.0.0 to >=2.6.0 to address vulnerabilities SNYK-PYTHON-URLLIB3-14192442 and SNYK-PYTHON-URLLIB3-14192443.

@continue

continue Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@sestinj @Patrick-Erichsen Could you please re-run the failed test (macos-latest, 24) workflow? This appears to be a flaky test unrelated to the Python dependency upgrade in this PR.

2 similar comments
@continue

continue Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@sestinj @Patrick-Erichsen Could you please re-run the failed test (macos-latest, 24) workflow? This appears to be a flaky test unrelated to the Python dependency upgrade in this PR.

@continue

continue Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

@sestinj @Patrick-Erichsen Could you please re-run the failed test (macos-latest, 24) workflow? This appears to be a flaky test unrelated to the Python dependency upgrade in this PR.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Dec 8, 2025
@RomneyDa
RomneyDa merged commit f98ef55 into main Dec 8, 2025
58 of 60 checks passed
@RomneyDa
RomneyDa deleted the snyk-fix-8e8ebf65a676d785d0d7d1635a746715 branch December 8, 2025 18:34
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 8, 2025
@sestinj

sestinj commented Dec 10, 2025

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 1.36.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj

sestinj commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 1.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj

sestinj commented Jan 22, 2026

Copy link
Copy Markdown
Contributor Author

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer released size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants