Skip to content

Fixes contributte/forms-bootstrap#100 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vagovszky
Copy link

Fixes issue #100 - UploadInput field adds an extra unnecessary label to the HTML

@dakorpar
Copy link
Member

Hm, I'm not sure I want this...
This is how it looks now
image

This is how form looks after your edit:
image

Can U attach screenshots what's really bothering you? This is a BC that will change a lot of forms and I can't just publish this...

@vagovszky
Copy link
Author

vagovszky commented Oct 10, 2024

Hello dakorpar, I understand your concerns - you are responsible for the library and its compatibility. Note: I saw the same issue in v4 and v5. If you reject this change I will have to live with it. But it is really weird, that upload input label (html dom) is there twice.
See following screenshots:

  1. Without my change - note the big blank spece between rows.

image

Html:
image

  1. With my change

image

Html:
image

Note: Isn't it possible that you removed extra row of code in your example by mistake?

image

@dakorpar
Copy link
Member

so maybe you need to do this only for inline edits?
I'm not really a fan of doing changes that will change how things works in minor version changes...
If we are going to merge this then I'd like that you add this as option which can be turned on.
That way I can merge it, like this it will affect look & feel of existing projects and that's kinda no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants