Skip to content

Fix missing room display name when a room has no specified name #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix missing room display name when a room has no specified name #3822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/headless/plugins/muc/muc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1281,6 +1281,7 @@ class MUC extends ModelWithVCard(ModelWithMessages(ColorAwareModel(ChatBoxBase))
this.save({ name: identity.get('name') });
} else {
log.error(`No identity or name found for ${this.get('jid')}`);
this.save({ name: this.get('jid') });
Copy link
Member

@jcbrand jcbrand Aug 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request @yureitzk

In the past we used to store the JID as a fallback value for name for different entities, but stopped doing so because strictly speaking the JID is not the name and it's better to have an undefined name to make it clear that there is no known name value.

Instead, we have the getDisplayName method (which you mentioned in your PR description) that gets called to get the correct name to display for a entity (e.g. a MUC, occupant, roster contact or 1:1 chat).

So I think the fix needs to go into getDisplayName or code related to it.

Copy link
Author

@yureitzk yureitzk Aug 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this as well, but getDisplayName will not fallback to JID, since if name attribute is missing, get will return Symbol(lit-nothing) string. But the main issue was that the bookmark's name is also Symbol(lit-nothing) . You'll see this upon the next login, when converse will fetch the bookmarks from the server.

Also, when you click on this empty bookmark, the room's name in main UI will be set to the same empty string.

This problem will go away if the chat will get a proper name aka title.

Copy link
Member

@jcbrand jcbrand Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this as well, but getDisplayName will not fallback to JID, since if name attribute is missing, get will return Symbol(lit-nothing) string

Yes, so a better fix (more like a workaround until #3815 is fixed) is to check whether a Symbol(lit-nothing) string is returned and in that case fall back to the JID.

It's ugly, but it prevents us from having to set the name to the JID, which I'd like to avoid.

}
await this.getDiscoInfoFields();
await this.getDiscoInfoFeatures();
Expand Down