feat(register): provider autocomplete (addresses #2740) #3892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and new setting \n\n- Replace plain domain input with autocomplete component (prefix filter)\n- Expose setting (array of provider domains)\n- Import autocomplete component in register plugin\n- Docs: add configuration section for (with example)\n\nAddresses conversejs#2740 (bounty/good-first-issue).
…e \n\n- Use property bindings for .list and .data (remove quoted strings)\n- Trigger suggestions on '@' with min_chars=1\n- Merge configured into domain list\n\nAddresses conversejs#2929 (bounty).
|
Update: also fixed provider autocomplete in Add Contact modal (bindings + |
…player - <figure role=group aria-label> and <audio aria-label tabindex=0 preload=metadata> - Caption/hostname continues to render when not hidden Addresses conversejs#3382 (bounty): improve screen reader access to play controls.
|
Added accessibility improvements for the audio player (fixes #3382):
Tested with keyboard-only navigation; happy to tweak ARIA per your guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now also fixes provider autocomplete in the Add Contact modal:
.listand.data(were passed as strings)@withmin_chars=1registration_providersinto the JID domain listThis complements the registration form autocomplete and addresses #2929 as well.