ci: use actions/setup-python with caching - #1933
Open
nschonni wants to merge 1 commit into
Open
Conversation
nschonni
marked this pull request as draft
August 25, 2026 20:06
gmarull
reviewed
Aug 25, 2026
gmarull
left a comment
gmarull
left a comment
Member
There was a problem hiding this comment.
we use a custom docker image for fw builds, so this should not be needed
nschonni
force-pushed
the
ci-setup-python
branch
from
August 25, 2026 20:34
d8c9a28 to
cd6289f
Compare
Signed-off-by: Nick Schonning <nschonni@gmail.com>
nschonni
force-pushed
the
ci-setup-python
branch
from
August 25, 2026 20:35
cd6289f to
befbcee
Compare
nschonni
marked this pull request as ready for review
August 25, 2026 20:36
Contributor
Author
|
@gmarull sorry, I didn't pick that up orginally. I rebased out all the jobs that used the custom images, and just left the 2 that were running on the stock Ubuntu image. No worries if you're not interested though |
nschonni
commented
Aug 25, 2026
| python-version: "3.13" | ||
|
|
||
| - name: Install ruff | ||
| run: pip install ruff |
Contributor
Author
There was a problem hiding this comment.
Instead of doing this, https://github.com/astral-sh/ruff-action could potentially be used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed it was only being used in the doc-linkscheck workflow, so used it consistently throughout the jobs, and used the built-in pip caching.
The
python-versionvalue of 3.13 was just based on the single use, and potentially could be unpinned to keep using the version shipped with the runner. Alternately at python verson file could live at the root for consitency.