Skip to content

fix(examples): wire CORS_ORIGINS into the CORS middleware in 10-production-boilerplate #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hashi-divyansh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(examples): wire CORS_ORIGINS into the CORS middleware in 10-production-boilerplate #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/10-production-boilerplate/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ DATABASE_DSN=./data/app.db
JWT_SECRET=your-super-secret-jwt-key-change-in-production
JWT_EXPIRATION=24h

# CORS
# CORS (comma-separated allowed origins; "*" allows any origin)
CORS_ORIGINS=http://localhost:3000,http://localhost:8080
```

Expand Down
4 changes: 3 additions & 1 deletion examples/10-production-boilerplate/cmd/api/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,9 @@ func main() {
// Global middleware
router.Use(middleware.Logger())
router.Use(middleware.Recovery())
router.Use(middleware.CORS())
router.Use(middleware.CORSWithConfig(middleware.CORSConfig{
AllowOrigins: cfg.CORSOrigins,
}))

// Health check endpoint
router.Handle("GET", "/health", func(c *fursy.Context) error {
Expand Down
6 changes: 3 additions & 3 deletions examples/10-production-boilerplate/internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ type Config struct {
JWTSecret []byte
JWTExpiration time.Duration

// CORS settings
CORSOrigins []string
// CORS settings: comma-separated list of allowed origins.
CORSOrigins string
}

// Load loads configuration from environment variables.
Expand All @@ -38,7 +38,7 @@ func Load() *Config {
DatabaseDSN: getEnv("DATABASE_DSN", "./data/app.db"),
JWTSecret: []byte(getEnv("JWT_SECRET", "your-super-secret-jwt-key-change-in-production")),
JWTExpiration: jwtExpiration,
CORSOrigins: []string{getEnv("CORS_ORIGINS", "http://localhost:3000,http://localhost:8080")},
CORSOrigins: getEnv("CORS_ORIGINS", "http://localhost:3000,http://localhost:8080"),
}
}

Expand Down