osbuild: re-arrange manifests; tweak runvm-osbuild #3734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm planning to break them up a little and having them in their own directory will be useful for that.
They aren't used in the deploy-via-container path so let's make them not required if the caller happens to not include them.
jlebon
previously approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Comments at the top of these new files would be helpful since as you said we're not actually planning to use these ourselves.
There was a problem hiding this comment.
Sorry, I meant mentioning the podman use case here, but not worth another respin!
Currently there is nothing in platforms.yaml for hyperv so it can be shared across the two architectures we build it for today. We don't currently use this but will in the future.
Currently there is nothing in platforms.yaml for applehv so it can be shared across the two architectures we build it for today. We don't currently use this but will in the future.
This isn't used today but will help with some automation I am building so that the process won't break in the future when we switch to defining the `qemu` pieces in this file.
Sometimes I iterate on this inside the supermin VM and the script fails on the second and subsequent runs. Let's just make it not make /dev/loop-control if it already exists.
We were using /processed.json because we run this inside a supermin VM which is essentially an entire root filesystem that's throwaway, but there's a new case where we might want to run it outside of a supermin VM for the podman folks so let's not pollute the root dir and use a temporary directory instead.
dustymabe
force-pushed
the
dusty-osbuild
branch
from
8ab1287 to
f51455b
Compare
jlebon
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Sorry, I meant mentioning the podman use case here, but not worth another respin!
dustymabe
added a commit
to dustymabe/build-podman-machine-os-disks
that referenced
this pull request
Feb 17, 2024
The pieces needed for this to work landed in coreos/coreos-assembler#3734
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The podman folks are going to start building their own disk images based off a derived container image built from our FCOS base container image. Rearranging things slightly in this repo will make it easier for them to re-use our image defnitions for now. See https://github.com/dustymabe/build-podman-machine-os-disks/tree/main
Having the podman team share our manifests like this isn't the long term solution. The long term solution is for the image definitions to live somewhere like osbuild/images and have everyone consume that. This change is part of a strategic short term play to get podman unblocked for Podman V5.