kola/testiso: fix pxe-*.rootfs-appended test on s390x #4049
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Until new, based on F42, |
dustymabe
reviewed
Mar 21, 2025
On s390x, `mk-s390image` is used to create a bootable `pxelinux.0` image from the live-kernel, live-initramfs, and cmdline. Because the cmdline doesn't include `coreos.liveiso`, systemd starts the `coreos-livepxe-rootfs.service`, which checks for the presence of the `coreos.live.rootfs_url` karg or the `/etc/coreos-live-rootfs` file, but neither is present. At the same time, `kola` generates a concatenated initramfs. This PR uses that initramfs as input for `mk-s390image`.
nikita-dubrovskii
force-pushed
the
s390x_fix_pxe_rootfs_appended
branch
from
3350dea to
48ec544
Compare
dustymabe
approved these changes
Mar 21, 2025
|
Converted this to draft because we are blocked on F42 COSA for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On s390x,
mk-s390imageis used to create a bootablepxelinux.0image from the live-kernel, live-initramfs, and cmdline. Because the cmdline doesn't includecoreos.liveiso, systemd starts thecoreos-livepxe-rootfs.service, which checks for the presence of thecoreos.live.rootfs_urlkarg or the/etc/coreos-live-rootfsfile, but neither is present. At the same time,kolagenerates a concatenated initramfs. This PR uses that initramfs as input formk-s390image.Issue: coreos/fedora-coreos-tracker#1883