-
Notifications
You must be signed in to change notification settings - Fork 55
Add container extension build and add new functions to utils #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2ee5bb4
to
988d308
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the direction this is going!
cb4d711
to
e508235
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, and but LGTM overall!
- The Podman team now handles this build independently, making it redundant in our CI; - Let's remove it for now, we can always readded it in the future if we need it. Signed-off-by: Renata Ravanelli <[email protected]>
- Introduce functions for manifest operations: push, release, and delete. - Add utility for COSA remote build operations; - Refactor build-node-image no reflect the changes. Signed-off-by: Renata Ravanelli <[email protected]>
- Add Extensions Container build as part of the job as a new stage. Signed-off-by: Renata Ravanelli <[email protected]>
- Add support to create manifests using the image digest instead of tags only; - Update build-node-image job to reflect it. Signed-off-by: Renata Ravanelli <[email protected]>
e508235
to
3875e20
Compare
- Prepare yum repos file upfront and feed it to both the node image build and the extensions build for consistency. This also avoids the subtle `\$(pwd)` usage in the secret argument. - Tweak the stage names a bit to make them more consistent. - Fix authfile handling. Don't use `None`; I don't think that's a valid Groovy value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great, thank you!
I took the liberty to push some tweaks on top. Assuming you agree and you've successfully tested this, feel free to merge!
No description provided.