*: add coderabbit configuration#2248
Merged
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (8)
📝 WalkthroughWalkthroughAdds ChangesCodeRabbit configuration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Binary size report (
|
| Size | |
|---|---|
Base (main) |
21MiB |
| PR (#2248) | 21MiB |
| Delta | +0B (0.00%) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.coderabbit.yaml:
- Around line 151-200: Update the tool configuration alongside the existing
disabled linters to explicitly disable both clang and cppcheck, ensuring they
cannot run against this Go repository’s C files. Leave the other tool settings
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 97dc8999-2b14-47e9-9dea-a97a55b99c26
📒 Files selected for processing (1)
.coderabbit.yaml
📜 Review details
⏰ Context from checks skipped due to timeout. (8)
- GitHub Check: Test ignition-validate (1.26.x, windows-latest)
- GitHub Check: Test ignition-validate (1.26.x, macos-latest)
- GitHub Check: Build container image
- GitHub Check: Check binary size
- GitHub Check: Test (1.25.x)
- GitHub Check: Test (1.26.x)
- GitHub Check: tmt-tests
- GitHub Check: Shellcheck
⚠️ CI failures not shown inline (2)
GitHub Actions: Release notes / Require release note: *: add CodeRabbit configuration
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1mif [ -n "skip-notes" ]; then�[0m
�[36;1m # Don't trust the label list in the event metadata, since runs�[0m
�[36;1m # can be scheduled out of order and the list might be stale.�[0m
�[36;1m label=$(curl --no-progress-meter \�[0m
�[36;1m -H "Accept: application/vnd.github+json" \�[0m
�[36;1m -H "Authorization: token ***" \�[0m
�[36;1m "https://api.github.com/repos/coreos/ignition/pulls/2248" |�[0m
�[36;1m jq '.labels[] | select(.name == "skip-notes")')�[0m
�[36;1m if [ -n "${label}" ]; then�[0m
�[36;1m echo "PR has skip-notes label; skipping"�[0m
�[36;1m exit 0�[0m
�[36;1m fi�[0m
�[36;1mfi�[0m
�[36;1mdiffinfo=$(curl --no-progress-meter \�[0m
�[36;1m -H "Accept: application/vnd.github+json" \�[0m
�[36;1m -H "Authorization: token ***" \�[0m
�[36;1m "https://api.github.com/repos/coreos/ignition/compare/7feb4ce111db204d81bebd7fb5dfb8ffa5514f9e...23f47163dd3577a9fa5ff402a75f257a2f7199f2" |�[0m
�[36;1m jq '.files[] | select(.filename == "docs/release-notes.md")')�[0m
�[36;1mif [ -z "${diffinfo}" ]; then�[0m
�[36;1m echo "Found no changes to docs/release-notes.md."�[0m
�[36;1m if [ -n "skip-notes" ]; then�[0m
�[36;1m echo "To ignore, add skip-notes label to PR."�[0m
�[36;1m fi�[0m
�[36;1m exit 1�[0m
�[36;1mfi�[0m
�[36;1mecho "Found change to docs/release-notes.md."�[0m
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
Found no changes to docs/release-notes.md.
To ignore, add skip-notes label to PR.
##[error]Process completed with exit code 1.
GitHub Actions: Release notes / 0_Require release note.txt: *: add CodeRabbit configuration
Conclusion: failure
##[group]Run set -euo pipefail
�[36;1mset -euo pipefail�[0m
�[36;1mif [ -n "skip-notes" ]; then�[0m
�[36;1m # Don't trust the label list in the event metadata, since runs�[0m
�[36;1m # can be scheduled out of order and the list might be stale.�[0m
�[36;1m label=$(curl --no-progress-meter \�[0m
�[36;1m -H "Accept: application/vnd.github+json" \�[0m
�[36;1m -H "Authorization: token ***" \�[0m
�[36;1m "https://api.github.com/repos/coreos/ignition/pulls/2248" |�[0m
�[36;1m jq '.labels[] | select(.name == "skip-notes")')�[0m
�[36;1m if [ -n "${label}" ]; then�[0m
�[36;1m echo "PR has skip-notes label; skipping"�[0m
�[36;1m exit 0�[0m
�[36;1m fi�[0m
�[36;1mfi�[0m
�[36;1mdiffinfo=$(curl --no-progress-meter \�[0m
�[36;1m -H "Accept: application/vnd.github+json" \�[0m
�[36;1m -H "Authorization: token ***" \�[0m
�[36;1m "https://api.github.com/repos/coreos/ignition/compare/7feb4ce111db204d81bebd7fb5dfb8ffa5514f9e...23f47163dd3577a9fa5ff402a75f257a2f7199f2" |�[0m
�[36;1m jq '.files[] | select(.filename == "docs/release-notes.md")')�[0m
�[36;1mif [ -z "${diffinfo}" ]; then�[0m
�[36;1m echo "Found no changes to docs/release-notes.md."�[0m
�[36;1m if [ -n "skip-notes" ]; then�[0m
�[36;1m echo "To ignore, add skip-notes label to PR."�[0m
�[36;1m fi�[0m
�[36;1m exit 1�[0m
�[36;1mfi�[0m
�[36;1mecho "Found change to docs/release-notes.md."�[0m
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
Found no changes to docs/release-notes.md.
To ignore, add skip-notes label to PR.
##[error]Process completed with exit code 1.
🔇 Additional comments (1)
.coderabbit.yaml (1)
1-150: LGTM!Also applies to: 201-202
prestist
changed the title
prestist
force-pushed
the
coderabbit-config
branch
2 times, most recently
from
July 21, 2026 18:55
9778706 to
daacd44
Compare
Member
|
Not sure if you want to do the same, but https://github.com/coreos/coreos-assembler/pull/4597/changes#diff-5666075b2557144f70919b913905272043d5f45e4094e28a2238ce0f074f76deR3 should disable the |
prestist
force-pushed
the
coderabbit-config
branch
from
July 22, 2026 13:53
daacd44 to
a1a0240
Compare
Add .coderabbit.yaml to configure automated code reviews. Key settings: - Exclude vendor/ from reviews - Path-specific instructions for frozen specs, experimental spec, providers, stages, and tests - PR title check enforcing 'subsystem: description' convention - Enable request-changes workflow - Disable irrelevant language-specific linters (including clang and cppcheck)
prestist
force-pushed
the
coderabbit-config
branch
from
July 22, 2026 17:38
a1a0240 to
cbe4a08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.coderabbit.yamlto configure automated CodeRabbit code reviewsvendor/from reviews and add path-specific review instructions for frozen config specs, experimental spec, providers, stages, resource fetching, tests, and docssubsystem: descriptionconvention), request-changes workflow, and disable ~20 irrelevant language-specific lintersDetails
Review behavior:
chillprofile with request-changes workflow enabledWIP/DO NOT MERGEtitlesPath instructions (13 rules):
config/v3_0/throughconfig/v3_6/-- frozen specs, flag any modificationsconfig/v3_7_experimental/-- check for./generateand translation updatesconfig/**-- stable API, backward compatibilityinternal/exec/stages/-- fixed stage list, declarative onlyinternal/providers/-- retry, empty config, docs, needs-netinternal/resource/-- security-critical, secure defaultstests/-- registry import, table-driven testsdocs/-- platform documentation enforcementTools enabled: golangci-lint, shellcheck, yamllint, markdownlint, hadolint, actionlint, zizmor, gitleaks, trufflehog
Tools disabled: ruff, biome, eslint, phpstan, phpmd, phpcs, swiftlint, detekt, rubocop, flake8, pylint, oxc, stylelint, htmlhint, clippy, brakeman, fortitudeLint, shopifyThemeCheck, luacheck, prismaLint, sqlfluff, squawk, dotenvLint, buf