-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 2021 edition + Remove authors
entry
#35
Conversation
No changes, just keeping up with the times.
`git log` is canonical for this, no reason to have the person who happened to create the project be listed explicitly here. As of recent Rust, this field is no longer required, probably for that reason.
To match what we use elsewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -3,6 +3,7 @@ name = "coreos-stream-metadata" | |||
version = "0.1.0" | |||
edition = "2021" | |||
license = "Apache-2.0" | |||
rust-version = "1.60.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that if we have any ambitions of using this crate in RHEL 8, e.g. in coreos-installer, this currently needs to be 1.58.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, it's easy enough to just do #37 for now for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, RHEL 8 CoreOS. The OCP 4.12 buildroot still has 1.58.1. I don't know if there are plans to bump Rust for 4.13, but usually we've stuck with what's currently available to us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we just need to ask to have it bumped. I suspect going forward we could probably ensure we inherit latest RHEL8 - the problem AIUI is today it's a manual bump process. But we just need to ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into it a bit more. It looks like RHEL 8.6 and 9.0 still have Rust 1.58, though 1.62 is available in the 8.7 and 9.1 betas.
Bump to 2021 edition
No changes, just keeping up with the times.
Remove
authors
entrygit log
is canonical for this, no reason to have the personwho happened to create the project be listed explicitly here.
As of recent Rust, this field is no longer required, probably
for that reason.