-
Notifications
You must be signed in to change notification settings - Fork 817
Implementing Parquet Converter #6716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alanprot
wants to merge
9
commits into
cortexproject:master
Choose a base branch
from
alanprot:parquet-converter
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0c7c06
to
2eec8b9
Compare
Signed-off-by: alanprot <[email protected]>
57efb1c
to
5e75bc8
Compare
Signed-off-by: alanprot <[email protected]>
5e75bc8
to
d820fd5
Compare
yeya24
reviewed
Apr 24, 2025
yeya24
reviewed
Apr 24, 2025
) | ||
|
||
type CompactionMark struct { | ||
Version int `json:"version"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add a comment about what this version actually means. It is the same as the version of the parquet file schema and updating version will trigger a rewrite of the parquet file?
yeya24
reviewed
Apr 24, 2025
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
Signed-off-by: alanprot <[email protected]>
01a64a4
to
2497df1
Compare
Signed-off-by: alanprot <[email protected]>
2497df1
to
46e3114
Compare
3d72c44
to
cc6d121
Compare
Signed-off-by: alanprot <[email protected]>
cc6d121
to
4fa4df6
Compare
Signed-off-by: alanprot <[email protected]>
fa8300a
to
1c8eda0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implementing parquet converter:
The documentation of this component is hidden for now as the feature is not code complete (We need to create the parquet queriable).
Which issue(s) this PR fixes:
Partially Fixes #6712
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]