Major refactor fo loadFormData. _rlv now reloads last values whether a user has changed them or not. Connection fields now reliably load last values. Added multiple retries to make sure. #554
+809
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a user has changed them or not. Connection fields now reliably load last values. Added multiple retries to make sure. Refactors form data loading to enhance reliability, modularity, and error handling when restoring persistent form fields . Introduces robust connection field hydration with retry logic and event-driven updates, reducing race conditions and ensuring consistent restoration across various field types. Converted some code to vanilla JS ready for the KTL-NG (Not Chosen & Redactor as Jquery Plugins). Improves maintainability by modularizing field hydration, handling corrupted storage, and optimizing field-specific logic.
There was a problem hiding this comment.
Pull request overview
This PR refactors the persistent form data loading mechanism to improve reliability and maintainability. The key improvements include modularizing field hydration logic, adding robust retry mechanisms for connection fields, implementing event-driven updates, and migrating portions of the code to vanilla JavaScript in preparation for reducing jQuery dependencies.
Key Changes:
- Introduced retry logic with exponential backoff and event-driven updates for connection field hydration to handle race conditions
- Refactored monolithic form loading into separate, focused hydration functions for each field type
- Added enhanced error handling for corrupted storage data with graceful fallbacks
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…d improves field value handling Unifies and streamlines scene/view loaded marking, replacing duplicated code with reusable functions for improved maintainability. Enhances field hydration logic for text, connection, and multiple-choice fields with better attribute escaping, input normalization, and robust error handling. Removes unreliable event-based connection hydration retries, switching to simpler logic for more predictable behavior. Fixes typos in selector class names to ensure correct event triggering. Refactors persistent form hydration and improves reliability Streamlines scene and view loaded logic by consolidating marking into reusable functions, improving maintainability and event consistency. Enhances field hydration for text, connection, and multiple-choice types with better value normalization, robust error handling, and improved attribute escaping. Removes unreliable event-based connection hydration retries for more predictable field population. Corrects class name typos to ensure events trigger as intended. Addresses maintainability, hydration accuracy, and user experience for persistent forms.
… into fix/_rlv-reloading-connection-fields
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 17 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Enhances connection field hydration with verification and retry logic, ensuring field values are correctly applied before finalizing persistence. Adds pending-save queuing to prevent data loss during hydration, and introduces exponential backoff for retries, reducing UI glitches and persistence errors. Improves boolean field handling and normalizes value checks for more robust data application.
… into fix/_rlv-reloading-connection-fields
Refactors form data hydration logic to better handle Knack mutations after connection loads, preventing loss of restored values. Adds rating widget persistence and refines date/time field handling for reliability. Keeps cached values across refreshes until submit, scene change, or expiry. Fully tested in KTL-tutorials app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors form data loading to enhance reliability, modularity, and error handling when restoring persistent form fields. Knacks connection fields have a habit of loading later than the view and under past issues we have had they can mutate even after the knack connections load triggers. Most of this refactor is to gurantee that the connections load the correct value. Introduces robust connection field hydration with retry logic and event-driven updates, reducing race conditions and ensuring consistent restoration across various field types. Converted some code to vanilla JS ready for the KTL-NG (Not Chosen & Redactor as Jquery Plugins).
Improves maintainability by modularizing field hydration, handling corrupted storage, and optimizing field-specific logic.