fix(auth/ante): correct lowGasPrice calculation in TestEnsureMempoolFees

[Galoretka]

Fix logical error in TestEnsureMempoolFees test where lowGasPrice was incorrectly calculated.

Problem: math.LegacyNewDec(0).Quo(math.LegacyNewDec(100000)) equals 0, not 0.00001.
This meant that lowGasPrice was actually 0, which is not a "low" gas price but a zero price.

The test was supposed to verify behavior with a low gas price of 0.00001atom, but due to
the mathematical error (0 ÷ 100000 = 0), it was actually testing with zero gas price.

Fixed by changing the calculation to math.LegacyNewDec(1).Quo(math.LegacyNewDec(100000))
which correctly produces 0.00001.

This ensures the test properly validates the mempool fee logic with actual low gas prices
rather than zero gas prices.

Also fixed comment that incorrectly referenced TxHeightTimeoutDecorator instead of TxTimeoutHeightDecorator in basic.go

Summary by CodeRabbit

• Bug Fixes

  • Improved mempool fee validation by updating the minimum gas price in tests to a small positive value, ensuring more accurate fee sufficiency checks.

• Documentation

  • Corrected a comment to accurately reference the decorator name.

[coderabbitai]

📝 Walkthrough

Walkthrough

A comment in basic.go was corrected to accurately reference the TxTimeoutHeightDecorator type. In fee_test.go, the minimum gas price in a test was changed from zero to a small positive value, altering the fee validation logic in the test scenario.

Changes

Cohort / File(s)	Change Summary
Comment Correction x/auth/ante/basic.go	Fixed a typo in the comment above the AnteHandle method, correcting the decorator's type name.
Test Minimum Gas Price Update x/auth/ante/fee_test.go	Changed the minimum gas price in TestEnsureMempoolFees from zero to a small positive value.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Knowledge Base: Disabled due to Reviews > Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between b12485b and fe4fa71.

📒 Files selected for processing (2)

• x/auth/ante/basic.go (1 hunks)
• x/auth/ante/fee_test.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Summary

🔇 Additional comments (2)

x/auth/ante/basic.go (1)

201-201: LGTM! Comment correction improves documentation accuracy.

The comment now correctly references TxTimeoutHeightDecorator, which matches the actual struct type defined on line 183. This documentation fix enhances code clarity.

x/auth/ante/fee_test.go (1)

103-103: LGTM! Critical fix for test logic correctness.

This change corrects a significant logical error where lowGasPrice was calculated as zero instead of the intended 0.00001. The fix ensures the test properly validates mempool fee logic with an actual low but non-zero gas price, aligning with the test's purpose and the variable name lowGasPrice.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.