Skip to content

chore: improve example env #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: improve example env #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Which type of ethereum testnet to run locally (pow|pos)
ETH_TESTNET_TYPE="pow"
ETH_TESTNET_TYPE="pos"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer pow for the example file. I usually run pow if I don't have to run pos


# SP1_PROVER={network|local|mock}
SP1_PROVER=mock
Expand All @@ -23,10 +23,13 @@ E2E_PROOF_TYPE=groth16
# Optional tag for eth light client to use in E2E tests
# Either an empty string, or 'local', means it will use the local binary in the repo, unless running in mock mode
# Otherwise, it will download the binary from the release at the specified tag
E2E_WASM_LIGHT_CLIENT_TAG="cw-ics08-wasm-eth-vX.Y.Z"
E2E_WASM_LIGHT_CLIENT_TAG="local"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, cw-ics08-wasm-eth-vX.Y.Z format should be mentioned in the comments above


# URL of the Tendermint RPC node for SP1 fixture generation
# URL of the Tendermint RPC node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this env var is used elsewhere at the moment. So isn't true that it is used for SP1 fixture generation?

TENDERMINT_RPC_URL=http://public-celestia-mocha4-consensus.numia.xyz/
# URL of the Ethereum RPC node
# use https://ethereum-sepolia.publicnode.com/ for the Eth Sepolia testnet
RPC_URL=https://ethereum-holesky-rpc.publicnode.com
Comment on lines +30 to +32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?


# URL of the Ethereum RPC node for mainnet, used in shadowfork tests
ETH_RPC_URL=https://ethereum-rpc.publicnode.com
Expand Down