-
Notifications
You must be signed in to change notification settings - Fork 0
Workers API #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
azaddhirajkumar
wants to merge
4
commits into
main
Choose a base branch
from
edits-for-workers-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Workers API #2
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Script to create FTS index for hotel geo-spatial search | ||
| # This creates a Full Text Search index called 'hotel-geo-index' that enables proximity searches on hotel documents. | ||
| # | ||
| # Prerequisites: | ||
| # - Couchbase Server with Data API enabled | ||
| # - travel-sample bucket loaded with hotel documents in inventory.hotel collection | ||
| # - Hotels must have geo coordinates (geo.lat and geo.lon fields) for proximity search | ||
| # | ||
| # Usage: | ||
| # 1. Set your environment variables: | ||
| # export DATA_API_USERNAME="your_username" | ||
| # export DATA_API_PASSWORD="your_password" | ||
| # export DATA_API_ENDPOINT="your_endpoint" | ||
| # 2. Run this script: ./scripts/create-fts-index.sh | ||
|
|
||
| # Check if environment variables are set | ||
| if [ -z "$DATA_API_USERNAME" ] || [ -z "$DATA_API_PASSWORD" ] || [ -z "$DATA_API_ENDPOINT" ]; then | ||
| echo "Error: Please set the following environment variables:" | ||
| echo " DATA_API_USERNAME" | ||
| echo " DATA_API_PASSWORD" | ||
| echo " DATA_API_ENDPOINT" | ||
| exit 1 | ||
| fi | ||
|
|
||
| # Index configuration | ||
| INDEX_NAME="hotel-geo-index" | ||
| BUCKET_NAME="travel-sample" | ||
| SCOPE_NAME="inventory" | ||
|
|
||
| # Construct the URL | ||
| URL="https://${DATA_API_ENDPOINT}/_p/fts/api/bucket/${BUCKET_NAME}/scope/${SCOPE_NAME}/index/${INDEX_NAME}" | ||
|
|
||
| echo "Creating FTS index '${INDEX_NAME}' for geo-spatial hotel search..." | ||
| echo "URL: ${URL}" | ||
|
|
||
| # Create the FTS index with geo-spatial mapping | ||
| curl -X PUT "${URL}" \ | ||
| -u "${DATA_API_USERNAME}:${DATA_API_PASSWORD}" \ | ||
| -H "Content-Type: application/json" \ | ||
| -d '{ | ||
| "type": "fulltext-index", | ||
| "name": "hotel-geo-index", | ||
| "sourceType": "gocbcore", | ||
| "sourceName": "travel-sample", | ||
| "sourceParams": {}, | ||
| "planParams": { | ||
| "maxPartitionsPerPIndex": 1024, | ||
| "indexPartitions": 1 | ||
| }, | ||
| "params": { | ||
| "doc_config": { | ||
| "docid_prefix_delim": "", | ||
| "docid_regexp": "", | ||
| "mode": "scope.collection.type_field", | ||
| "type_field": "type" | ||
| }, | ||
| "mapping": { | ||
| "analysis": {}, | ||
| "default_analyzer": "standard", | ||
| "default_datetime_parser": "dateTimeOptional", | ||
| "default_field": "_all", | ||
| "default_mapping": { | ||
| "dynamic": true, | ||
| "enabled": false | ||
| }, | ||
| "default_type": "_default", | ||
| "docvalues_dynamic": false, | ||
| "index_dynamic": true, | ||
| "store_dynamic": false, | ||
| "type_field": "_type", | ||
| "types": { | ||
| "inventory.hotel": { | ||
| "dynamic": true, | ||
| "enabled": true, | ||
| "properties": { | ||
| "geo": { | ||
| "dynamic": false, | ||
| "enabled": true, | ||
| "fields": [ | ||
| { | ||
| "analyzer": "keyword", | ||
| "include_in_all": true, | ||
| "include_term_vectors": true, | ||
| "index": true, | ||
| "name": "geo", | ||
| "store": true, | ||
| "type": "geopoint" | ||
| } | ||
| ] | ||
| }, | ||
| "name": { | ||
| "dynamic": false, | ||
| "enabled": true, | ||
| "fields": [ | ||
| { | ||
| "analyzer": "standard", | ||
| "include_in_all": true, | ||
| "include_term_vectors": true, | ||
| "index": true, | ||
| "name": "name", | ||
| "store": true, | ||
| "type": "text" | ||
| } | ||
| ] | ||
| }, | ||
| "city": { | ||
| "dynamic": false, | ||
| "enabled": true, | ||
| "fields": [ | ||
| { | ||
| "analyzer": "standard", | ||
| "include_in_all": true, | ||
| "include_term_vectors": true, | ||
| "index": true, | ||
| "name": "city", | ||
| "store": true, | ||
| "type": "text" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "store": { | ||
| "indexType": "scorch", | ||
| "segmentVersion": 15 | ||
| } | ||
| } | ||
| }' | ||
|
|
||
| echo "" | ||
| echo "FTS index creation completed!" | ||
| echo "Note: The index is being built in the background. Use the hotel search endpoint once the index is ready." | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script currently executes the
curlcommand to create the FTS index but doesn't explicitly check for or handle potential failures fromcurl(e.g., network errors, HTTP 4xx/5xx errors from the API). If thecurlcommand fails, the script will still proceed to print the success messages (lines 135-136), which can be misleading.Could you enhance the script to check the exit status of the
curlcommand and report an error if it fails? Usingcurl -f(or--fail) makescurlexit with an error code on HTTP server errors, which can then be checked.This would make the script more robust and provide clearer feedback to the user if the index creation doesn't succeed.