-
Notifications
You must be signed in to change notification settings - Fork 16
Define observability interface between core SDK and the wrapper #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
765e2cb to
fe05347
Compare
dda08cd to
f453430
Compare
|
@DemetrisChr, @thejcfactor
|
| if (status == std::cv_status::timeout) { | ||
| // Return empty on timeout to enable implicit batching, | ||
| // even if the buffer contains data below the threshold | ||
| return {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would the consumers' response be when they receive an std::nullopt result from here? My understanding is that they would call take_buffer in that case. Wouldn't it make sense to return the buffer if that's what they would do? Or do we want to give the consumers more flexibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic might be different on whether the buffer is empty and when condition variable waiting timeout happened. For example, the wrapper might have its own sleep or yield the processor if it is empty but not timeout.
7f4206a to
9fc725c
Compare
62677c9 to
4d694ca
Compare
92c293e to
a24ebbd
Compare
a24ebbd to
e7eb5ad
Compare
No description provided.