Skip to content

Conversation

@DemetrisChr
Copy link
Contributor

Motivation

KV operations that encode the document content must create a request_encoding span.

Changes

For Insert, Replace, Upsert:

  • Defer the encoding of the content until the relevant method of collection_impl is called, which has access to the tracer and creates the top-level span. The insert/replace/upsert methods of collection_impl can now accept an std::function parameter that encodes the document.
  • Create a request_encoding span when invoking the function that provides the encoded document.
  • If replace/upsert/insert is called with an encoded document, then no request_encoding span is created.

@DemetrisChr DemetrisChr force-pushed the CXXCBC-744-request-encoding-spans branch from bfe5737 to fee29ee Compare October 29, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants