fix processEntry mode on caching tool #7515
Merged
+36
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torcolvin
reviewed
May 12, 2025
| @@ -74,6 +85,16 @@ func (p *processEntryGen) nodeWrites(ctx context.Context, node *sgwNode, delay t | |||
| ticker := time.NewTicker(delay) | |||
| defer ticker.Stop() | |||
| for { | |||
There was a problem hiding this comment.
Should this be a function to deduplicate above where this passes in a time.Ticker with 0 so that the first one is deduplicated from this?
If the delay is actually 0, are we supposed to run this function twice?
There was a problem hiding this comment.
Can't pass 0 into ticket hence why I just went for this approach. No wouldn't expect this to run twice if node has 0 delay.
torcolvin
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #7483 got merged processEnrty mode was broken due to some changes. Also needed to add ability to add configured number of channels per doc from system channels.
Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiIntegration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/000/