Skip to content

Conversation

@kidkidkid
Copy link
Collaborator

What type of PR is this?

Check the PR title.

  • This PR title match the format: [<type>][<scope>]: <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

@kidkidkid kidkidkid force-pushed the feat/ob_trans_refactor branch from b2710e3 to 2335100 Compare November 10, 2025 04:10
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...bservability/domain/trace/service/trace_service.go 76.92% 2 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   68.36%   68.36%   -0.01%     
==========================================
  Files         570      570              
  Lines       51562    51569       +7     
==========================================
+ Hits        35250    35254       +4     
- Misses      13573    13580       +7     
+ Partials     2739     2735       -4     
Flag Coverage Δ
unittests 68.36% <88.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bservability/domain/trace/entity/loop_span/span.go 78.47% <100.00%> (-1.09%) ⬇️
...servability/domain/trace/entity/loop_span/trans.go 73.33% <100.00%> (+0.22%) ⬆️
...bservability/domain/trace/service/trace_service.go 82.04% <76.92%> (+0.11%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cfcdc3...e5c2c6e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@CozeLoop CozeLoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aime code review: posted 3 inline comments focusing on concurrency safety with sync.Once, potential redundant filtering in Stat, and processor construction cost in GetTracesAdvanceInfo.

@kidkidkid kidkidkid merged commit 5a204f3 into main Nov 12, 2025
17 of 18 checks passed
@kidkidkid kidkidkid deleted the feat/ob_trans_refactor branch November 12, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants