fix: add use 5.010 to all test files for Perl 5.8.x protection#30
Merged
toddr merged 1 commit intocpan-authors:mainfrom Mar 21, 2026
Merged
Conversation
t/0use.t, t/export.t, and t/apache.t were the only test files without an explicit minimum-version guard. While Makefile.PL already has use 5.010 (PR cpan-authors#25) which prevents Perl 5.8.x from reaching the test phase, adding the guard to every test file provides defense in depth and keeps the test suite consistent. Fixes cpan-authors#29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
toddr-bot
added a commit
to toddr-bot/Net-Ident
that referenced
this pull request
Mar 22, 2026
cpanfile listed Fcntl and Config which are not used by Ident.pm (Fcntl was removed when PR cpan-authors#14 replaced fcntl() with blocking(0)). Errno is used but was missing from both cpanfile and PREREQ_PM. Also updates Changes with post-1.27 fixes that were merged but not recorded (PRs cpan-authors#25, cpan-authors#30, cpan-authors#31, cpan-authors#33). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
use 5.010;to the three test files (t/0use.t,t/export.t,t/apache.t) that were missing it. WhileMakefile.PLalready guards against Perl 5.8.x at configure time (PR #25), this ensures every test file consistently declares the minimum version — providing defense in depth and preventing confusing syntax errors if tests are somehow run directly on old perls.Fixes #29
Changes
use 5.010;tot/0use.t,t/export.t,t/apache.tTest plan
make test→ Result: PASS, 79 subtests)use 5.010;Generated by Kōan /fix
Quality Report
Changes: 3 files changed, 3 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline