test: add tests for XS functions modified in PR #184#189
Merged
toddr merged 1 commit intocpan-authors:mainfrom Mar 20, 2026
Merged
test: add tests for XS functions modified in PR #184#189toddr merged 1 commit intocpan-authors:mainfrom
toddr merged 1 commit intocpan-authors:mainfrom
Conversation
Add test coverage for XS functions changed in PR cpan-authors#184 and the related PR cpan-authors#186: - t/error_string.t: Tests XML_ErrorString() which was converted from CODE/char* to PPCODE/void with XPUSHs return semantics - t/get_base.t: Tests XML_GetBase()/XML_SetBase() which were converted from CODE/SV* to PPCODE/void with XPUSHs return semantics - t/element_decl.t: Tests generate_model() including EMPTY and ANY content model types that received explicit switch cases Addresses cpan-authors#188 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
toddr
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds dedicated test coverage for XS functions modified in PR #184 (and related PR #186) to ensure the compile-warning fixes and PPCODE conversion changes continue to work correctly.
Fixes #188
Changes
t/error_string.t— TestsXML_ErrorString()which was converted from CODE/char* to PPCODE/void with XPUSHs (5 tests)t/get_base.t— TestsXML_GetBase()/XML_SetBase()which were converted from CODE/SV* to PPCODE/void with XPUSHs (5 tests)t/element_decl.t— Testsgenerate_model()including EMPTY and ANY content model types that received explicit switch cases in PR fix: handle XML_CTYPE_EMPTY/ANY in generate_model switch #186 (11 tests)Test plan
Coverage analysis
Functions with existing sufficient test coverage (no new tests needed):
startElement()— removed unused variables; heavily tested across 8+ existing test filesexternalEntityRef()—(void)POPscast; tested in external_ent.t, astress.t, g_void.tunknownEncoding()— removed unused variable; tested via encoding.tXML_ParseStream— removed unused variable; tested via stream.t and 3 other stream testsXML_GetSpecifiedAttributeCount— declaration-only change; tested in defaulted.tGenerated by Kōan /fix
Quality Report
Changes: 3 files changed, 154 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline