Require perl 5.008 minimum, remove pre-5.008 compat code#195
Merged
toddr merged 1 commit intocpan-authors:mainfrom Mar 22, 2026
Merged
Conversation
- Makefile.PL: bump MIN_PERL_VERSION to 5.008, drop $] >= 5.006001 guard on ExtUtils::Liblist (always true now) - Expat.xs: remove PL_sv_* polyfills (pre-5.005), SvUTF8_on #ifdef guard (pre-5.006), LEAKTEST safexmalloc/safexrealloc (removed in 5.005), USE_THREADS+PATCHLEVEL==6 dTHX shim (5.6 only), patchlevel.h include - Expat.pm: remove dead $] < 5.008 tied-handle branch Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sets the minimum perl version to 5.008 and removes all XS/Perl code that only existed to support older perls.
Why
The CI matrix already starts at 5.8 — the code was carrying dead compatibility shims for perls that haven't been tested in years. The oldest CPAN Testers results for this dist are all 5.8+. Time to match the declared minimum to reality.
How
MIN_PERL_VERSIONbumped from5.00405to5.008. Removed the$] >= 5.006001guard onExtUtils::Liblist(always true now).PL_sv_undef/PL_sv_no/PL_sv_yes/PL_napolyfills (pre-5.005),#ifdef SvUTF8_onguard and fallback macros (pre-5.006),LEAKTESTsafexmalloc/safexreallocbranches (removed from perl in 5.005),USE_THREADS && PATCHLEVEL==6dTHXshim (5.6 only),#include "patchlevel.h"(no longer needed).$] < 5.008tied-handle branch inparse().since-perl: 5.8) unchanged — already correct.Testing
Full test suite passes: 47 files, 363 tests. Built and tested locally on perl 5.42.
🤖 Generated with Claude Code
Quality Report
Changes: 3 files changed, 5 insertions(+), 43 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline