Skip to content

Silence known deprecations from http-signatures package #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Draft

Silence known deprecations from http-signatures package #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
100008d
Silence known deprecations from http-signatures package
timkelty Feb 4, 2025
8fc2384
Merge branch '1.x' into bugfix/http-signatures-deprecations
timkelty Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions src/Helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,29 @@ public static function makeGatewayApiRequest(iterable $headers): ResponseInterfa
throw new Exception('Gateway API requests require a URL.');
}

$context = Helper::createSigningContext($headers->keys());
$request = new Request(
'HEAD',
(string) $url,
$headers->all(),
);
// Silence known dynamic property deprecations from HttpSignatures
return self::withoutDeprecationErrors(function() use ($headers, $url) {
$context = Helper::createSigningContext($headers->keys());
$request = new Request(
'HEAD',
(string) $url,
$headers->all(),
);

return Craft::createGuzzleClient()->send(
$context->signer()->sign($request)
);
return Craft::createGuzzleClient()->send(
$context->signer()->sign($request)
);
});
}

private static function withoutDeprecationErrors(callable $callback): mixed
{
$errorLevel = error_reporting(error_reporting());
error_reporting($errorLevel & ~E_DEPRECATED);
$return = $callback();
error_reporting($errorLevel);

return $return;
}

/**
Expand Down