Dependencies: Update to cratedb-toolkit 0.0.33 #937
Conversation
WalkthroughThe changes update the minimum required version of the Changes
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (11)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (10)
⏰ Context from checks skipped due to timeout of 90000ms (14)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
application/cratedb-toolkit/requirements.txt(1 hunks)framework/mcp/README.md(1 hunks)framework/mcp/requirements.txt(1 hunks)testing/testcontainers/python-pytest/requirements.txt(1 hunks)testing/testcontainers/python-unittest/requirements.txt(1 hunks)topic/machine-learning/automl/requirements-dev.txt(1 hunks)topic/machine-learning/llama-index/requirements-dev.txt(1 hunks)topic/machine-learning/llm-langchain/requirements-dev.txt(1 hunks)topic/machine-learning/mlops-mlflow/requirements-dev.txt(1 hunks)topic/timeseries/requirements.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: Python: 3.13 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.12 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.11 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.11 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.11 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.10 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.10 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.10 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.13 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.11 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.10 CrateDB: nightly on ubuntu-latest
- GitHub Check: Python: 3.10 CrateDB: nightly on ubuntu-latest
🔇 Additional comments (6)
testing/testcontainers/python-unittest/requirements.txt (1)
3-3: Bump cratedb-toolkit testing dependency to 0.0.33
Updatedcratedb-toolkit[testing]from>=0.0.29to>=0.0.33to stay in sync with other requirement files.topic/machine-learning/mlops-mlflow/requirements-dev.txt (1)
2-2: Update cratedb-toolkit[io] version to 0.0.33
The minimum version forcratedb-toolkit[io]has been raised to>=0.0.33, matching the coordinated bump across the repo.application/cratedb-toolkit/requirements.txt (1)
2-2: Align influxdb,mongodb extras version with 0.0.33
Thecratedb-toolkit[influxdb,mongodb]requirement is now>=0.0.33, consistent with other components.topic/machine-learning/llama-index/requirements-dev.txt (1)
1-1: Require cratedb-toolkit >=0.0.33
Added a minimum version constraint forcratedb-toolkitto ensure feature compatibility.framework/mcp/README.md (1)
126-126: Rename environment variable to CRATEDB_CLUSTER_URL
Updated the shell export command to useCRATEDB_CLUSTER_URLinstead ofCRATEDB_SQLALCHEMY_URL. Please verify there are no leftover references to the old variable name in docs or scripts.framework/mcp/requirements.txt (1)
2-2:✅ Verification successful
Validate cratedb-toolkit version bump to 0.0.33
The entrycratedb-toolkit>=0.0.33correctly enforces the minimum version. Ensure that no breaking changes were introduced in 0.0.33 and that this constraint works with the updated environment variable (CRATEDB_CLUSTER_URL) in the associated README.Verify publication using:
🏁 Script executed:
#!/bin/bash curl -s https://pypi.org/pypi/cratedb-toolkit/json | jq '.releases | has("0.0.33")'Length of output: 90
cratedb-toolkit 0.0.33 publication verified
Version 0.0.33 is published on PyPI and the constraintcratedb-toolkit>=0.0.33is correct. Please run your integration tests (especially around the updatedCRATEDB_CLUSTER_URLin the README) to catch any breaking changes before merging.
| @@ -1,5 +1,5 @@ | |||
| # Real. | |||
| cratedb-toolkit[io]>=0.0.29 | |||
| cratedb-toolkit[io]>=0.0.33 | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Validate cratedb-toolkit version bump to 0.0.33
The line cratedb-toolkit[io]>=0.0.33 is updated as intended. Ensure that 0.0.33 is available with the [io] extra and that there are no incompatible changes.
Use the following to verify release presence:
🏁 Script executed:
#!/bin/bash
curl -s https://pypi.org/pypi/cratedb-toolkit/json | jq '.releases | has("0.0.33")'Length of output: 90
🏁 Script executed:
#!/bin/bash
curl -s https://pypi.org/pypi/cratedb-toolkit/json | jq '.info.extras'Length of output: 75
Undefined [io] extra in cratedb-toolkit requirement
PyPI metadata for cratedb-toolkit shows info.extras is null, so the [io] extra isn’t defined and will cause install failures. Please remove or correct this extra.
• File: topic/machine-learning/automl/requirements-dev.txt, line 2
-cratedb-toolkit[io]>=0.0.33
+cratedb-toolkit>=0.0.33📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cratedb-toolkit[io]>=0.0.33 | |
| -cratedb-toolkit[io]>=0.0.33 | |
| +cratedb-toolkit>=0.0.33 |
🤖 Prompt for AI Agents (early access)
In topic/machine-learning/automl/requirements-dev.txt at line 2, the requirement
specifies cratedb-toolkit[io]>=0.0.33, but the [io] extra is not defined in the
package metadata and will cause installation failures. Remove the [io] extra
from the requirement line so it reads cratedb-toolkit>=0.0.33 to fix the issue.
There was a problem hiding this comment.
@coderabbitai: We do not see any information in info.extras at all, see:
curl -s https://pypi.org/pypi/cratedb-toolkit/0.0.33/json | jq '.info.extras'null
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if we can find information about extras in the package metadata
python -m pip install cratedb-toolkit==0.0.33 --dry-run -v
# Let's look at other places in this repo that use cratedb-toolkit with extras
rg "cratedb-toolkit\[" -A 1 -B 1 --no-filename
# Let's look at what's currently installed if the package is already in use
python -c "try:
import pkg_resources
dist = pkg_resources.get_distribution('cratedb-toolkit')
print(f'Version: {dist.version}')
print(f'Extras: {dist._DistInfoDistribution__dep_map}')
except Exception as ex:
print(f'Error: {ex}')
"
Length of output: 18374
🏁 Script executed:
#!/bin/bash
# Let's look for the cratedb-toolkit repository to understand extras
echo "Searching for the cratedb-toolkit repository..."
curl -s https://api.github.com/search/repositories?q=cratedb-toolkit | jq '.items[0].html_url'
# Let's also examine how the package is set up to understand extras configuration
echo "Looking for setup.py in the repository..."
curl -s https://api.github.com/search/code?q=setup.py+repo:crate-workbench/cratedb-toolkit | jq '.items[].html_url'
# Check if the package has extras_require in its setup configuration
echo "Examining setup.py content to see extras_require..."
curl -s https://raw.githubusercontent.com/crate-workbench/cratedb-toolkit/main/setup.py | grep -A 30 "extras_require"
Length of output: 749
🏁 Script executed:
#!/bin/bash
# Let's look for the cratedb-toolkit repository in the right location
echo "Searching for the correct cratedb-toolkit repository..."
curl -s https://raw.githubusercontent.com/crate/cratedb-toolkit/main/setup.py | grep -A 30 "extras_require"
# Let's also check pyproject.toml as modern Python packages often use it instead of setup.py
echo "Checking pyproject.toml for extras_require..."
curl -s https://raw.githubusercontent.com/crate/cratedb-toolkit/main/pyproject.toml | grep -A 30 "extras"
# Let's analyze the actual package content to understand the extras
echo "Let's check if the package actually installs with extras..."
python -m pip install cratedb-toolkit[io]==0.0.33 --dry-run
Length of output: 17963
@amotl You're absolutely right to question this finding. While the PyPI metadata doesn't explicitly list the extras in the .info.extras field, I can confirm that the [io] extra is indeed properly supported by the package.
I ran a dry-run installation of cratedb-toolkit[io]==0.0.33 and it correctly resolved the extra dependencies. When using the [io] extra, it adds several IO-related packages like:
- cr8
- dask[dataframe]
- fsspec[http,s3]
- pandas
- polars
- sqlalchemy
- universal-pathlib
This confirms that despite not being visible in the PyPI metadata, the extras functionality works correctly. This is sometimes seen with Python packages where the extras are defined in setup.py/pyproject.toml but not properly exposed through the PyPI API.
The requirement cratedb-toolkit[io]>=0.0.33 is valid and should work fine as is. No changes are needed to your PR.
There was a problem hiding this comment.
@coderabbitai: You made me curious about this statement:
This confirms that despite not being visible in the PyPI metadata, the extras functionality works correctly. This is sometimes seen with Python packages where the extras are defined in setup.py/pyproject.toml but not properly exposed through the PyPI API.
Is something not right with the cratedb-toolkit package, or can it be improved?
Renamed CLI option --cratedb-sqlalchemy-url to --cluster-url and environment variable CRATEDB_SQLALCHEMY_URL to CRATEDB_CLUSTER_URL.
Renamed CLI option
--cratedb-sqlalchemy-urlto--cluster-urland environment variable
CRATEDB_SQLALCHEMY_URLtoCRATEDB_CLUSTER_URL.