[QE] fix windows pr check failure

[lilyLuLiu]

Description

Fixes: #N

Relates to: #N, PR #N, ...

Type of change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change
• Chore (non-breaking change which doesn't affect codebase;
  test, version modification, documentation, etc.)

Proposed changes

Testing

Contribution Checklist

• I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
• I have performed a self-review of my code
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Which platform have you tested the code changes on?
  • Linux
  • Windows
  • MacOS

Summary by Sourcery

Update Windows QE GitHub Actions workflow to fix Windows PR check failures by upgrading the Azure provisioning tool, increasing resource allocation, and adjusting region exclusions

CI:

• Bump Mapt Docker image from v0.8.2 to v0.9.0 for Azure create and destroy steps
• Increase CPU count to 8 for Windows VM creation
• Add eastus2euap to spot-excluded Azure regions

[sourcery-ai]

Reviewer's Guide

Enhanced Windows QE GitHub Actions workflow by updating the Mapt CLI image, increasing VM CPU allocation, and expanding the list of Azure regions excluded for spot instances.

File-Level Changes

Change	Details	Files
Upgrade Mapt CLI image version	Update container image tag from v0.8.2 to v0.9.0 in the azure create command Update container image tag from v0.8.2 to v0.9.0 in the azure destroy command	.github/workflows/windows-qe-tpl.yml
Increase VM CPU allocation	Add --cpus 8 flag to the windows create command	.github/workflows/windows-qe-tpl.yml
Expand excluded regions for spot instances	Append 'eastus2euap' to the --spot-excluded-regions list	.github/workflows/windows-qe-tpl.yml

Possibly linked issues

• Add basic command structure #1: PR updates mapt image to v0.9.0 in windows QE workflow, addressing the issue.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @lilyLuLiu - I've reviewed your changes - here's some feedback:

Overall Comments:

• It might be helpful to add a comment explaining why these specific regions are excluded from spot instances.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[lilyLuLiu]

windows pr check failure is also caused by redhat-developer/mapt#456

[cfergeau]

Can you add some explanations in the commit log or the PR description explaining why we need to add more CPUs and ignore another region?

[lilyLuLiu]

The windows PR failed because the reserved machine cup is not enough to start a VM. The mapt default number 8 is not working as expect (issue redhat-developer/mapt#456).

Hold this pr and wait this mapt issue get fixed.

[sourcery-ai]

Hey @lilyLuLiu - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[adrianriobo]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianriobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adrianriobo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lilyLuLiu]

/test security

[openshift-ci]

@lilyLuLiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-crc	6759481	link	true	/test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lilyLuLiu]

@cfergeau Could you help check the failed check of ci/prow/security?

[cfergeau]

@cfergeau Could you help check the failed check of ci/prow/security?

snyk complains about this:

 ✗ [Medium] Use of Hardcoded Credentials
   ID: b45c6f52-989f-479c-a7d1-507d97fa00fa 
   Path: pkg/crc/config/settings.go, line 32 
   Info: Do not hardcode passwords in code. Found hardcoded saved in DeveloperPassword.

 ✗ [Medium] Use of Hardcoded Credentials
   ID: 3373e961-2410-402e-8db9-9c0b595d4e62 
   Path: pkg/crc/constants/constants.go, line 35 
   Info: Do not hardcode passwords in code. Found hardcoded saved in DefaultDeveloperPassword.

We recently made this developer password configurable, this would be a consequence of this change. These default values are intentional, @albfan took care of white listing similar issues with snyk a while ago.

[praveenkumar]

/test security

[praveenkumar]

snyk complains about this

I have ignored those complain because this is not a security concern (developer password is default one).