Skip to content

requestId-spaces-removed#1247

Open
SEEDART007 wants to merge 1 commit intocredebl:mainfrom
SEEDART007:requestId-spaces-removed
Open

requestId-spaces-removed#1247
SEEDART007 wants to merge 1 commit intocredebl:mainfrom
SEEDART007:requestId-spaces-removed

Conversation

@SEEDART007
Copy link
Copy Markdown

@SEEDART007 SEEDART007 commented May 14, 2025

#1226 Used trim() function to remove any spaces in front or back of the requestId.

Signed-off-by: SEEDART007 <dashranger60@gmail.com>
@SEEDART007 SEEDART007 force-pushed the requestId-spaces-removed branch from 1c46e5a to 0e42702 Compare May 14, 2025 04:05
@sonarqubecloud
Copy link
Copy Markdown

@bhavanakarwade
Copy link
Copy Markdown
Contributor

Hello @SEEDART007,
Thank you for your interest.
We will review your PR, And let you know.

): Promise<Response> {
const { requestId } = query;
let { requestId } = query;
requestId = requestId.trim();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an interceptor in CREDEBL platform, can you please check if that helps in trim operation.

Copy link
Copy Markdown
Contributor

@GHkrishna GHkrishna Jul 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, we also have a validation pipe for req params and query params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants